Bug #15867
LoginCluster redirect broken with EnableBetaController: true
Start date:
Due date:
% Done:
100%
Estimated time:
Story points:
-
Release:
Release relationship:
Auto
Description
So this note was precient https://dev.arvados.org/issues/15107#note-27
The login redirect generated by Controller passes an empty "remote" which causes the target cluster to fail:
https://172.17.0.2:8000/login?remote=&return_to=https%3A%2F%2F172.17.0.3%2Fusers%2Fwelcome%3Freturn_to%3D%252F
{"errors":["Invalid remote cluster id (req-1dbjeioi2ubya1rjphw3)"],"error_token":"1574438263+155fa05c"}
Either controller shouldn't do that, or the API server should accept that (or both).
Related issues
Associated revisions
History
#1
Updated by Peter Amstutz almost 2 years ago
Updated by - Status changed from New to In Progress
#2
Updated by Peter Amstutz almost 2 years ago
- Status changed from In Progress to New
#3
Updated by Peter Amstutz almost 2 years ago
- Description updated (diff)
- Assigned To set to Tom Clegg
#4
Updated by Peter Amstutz almost 2 years ago
- Related to Task #15512: Review 15107-google-login added
#5
Updated by Peter Amstutz almost 2 years ago
- Related to deleted (Task #15512: Review 15107-google-login)
#6
Updated by Peter Amstutz almost 2 years ago
- Related to Story #15107: [controller] Implement native Google login (configurable as an alternative to sso-provider) added
#7
Updated by Peter Amstutz almost 2 years ago
- Description updated (diff)
#8
Updated by Tom Clegg almost 2 years ago
Updated by - Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|1b6b00b1f3f1a1931c27c69f1624d2c34e94a880.
#9
Updated by Peter Amstutz over 1 year ago
- Release set to 22
15867: Don't pass blank remote param.
fixes #15867
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>