Bug #15867

LoginCluster redirect broken with EnableBetaController: true

Added by Peter Amstutz 7 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Story points:
-
Release relationship:
Auto

Description

So this note was precient https://dev.arvados.org/issues/15107#note-27

The login redirect generated by Controller passes an empty "remote" which causes the target cluster to fail:

https://172.17.0.2:8000/login?remote=&return_to=https%3A%2F%2F172.17.0.3%2Fusers%2Fwelcome%3Freturn_to%3D%252F
{"errors":["Invalid remote cluster id (req-1dbjeioi2ubya1rjphw3)"],"error_token":"1574438263+155fa05c"}

Either controller shouldn't do that, or the API server should accept that (or both).


Related issues

Related to Arvados - Story #15107: [controller] Implement native Google login (configurable as an alternative to sso-provider)Resolved10/31/2019

Associated revisions

Revision 1b6b00b1 (diff)
Added by Tom Clegg 7 months ago

15867: Don't pass blank remote param.

fixes #15867

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz 7 months ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz 7 months ago

  • Status changed from In Progress to New

#3 Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
  • Assigned To set to Tom Clegg

#4 Updated by Peter Amstutz 7 months ago

  • Related to Task #15512: Review 15107-google-login added

#5 Updated by Peter Amstutz 7 months ago

  • Related to deleted (Task #15512: Review 15107-google-login)

#6 Updated by Peter Amstutz 7 months ago

  • Related to Story #15107: [controller] Implement native Google login (configurable as an alternative to sso-provider) added

#7 Updated by Peter Amstutz 7 months ago

  • Description updated (diff)

#8 Updated by Tom Clegg 7 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#9 Updated by Peter Amstutz 5 months ago

  • Release set to 22

Also available in: Atom PDF