Project

General

Profile

Actions
Copy link

Bug #15900

closed

[API] [Workbench1] [SDKs] ruby gems report wrong version number

Added by Tom Clegg almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
2020-01-02 Sprint
Story points:
-
Release:
Arvados 2.0 - Early 2020
Release relationship:
Auto

Description

Example:
  • sdk/ruby/arvados.gemspec reports itself as 1.4.1.timestamp1
  • services/api/Gemfile pins an arvados gem version by commit hash, and bundler writes "1.4.1.timestamp1" in Gemfile.lock
  • bundler succeeds at version 1.4.1.timestamp2
  • sometime later, a 1.4.2 tag is added somewhere in the repo
  • checkout version 1.4.1.timestamp2 and run bundler
  • bundler checks out the specified git hash, but the resulting arvados.gemspec now reports itself as 1.4.2.timestamp1
  • bundler fails at version 1.4.1.timestamp2

The "use git tag to figure out version at runtime" code used to use the latest tag reachable from HEAD, which makes recent/dev versions appear older than they really are (e.g., 1.4.2 isn't an ancestor of master) -- then it changed in ff48e70fd7cc41997a27c0b04bb38149a6abfa0d to report the highest version in the repo, which makes older/released versions appear newer than they really are.

Subtasks 1 (0 open — 1 closed)

Task #15903: Review 15900-gem-versionResolvedWard Vandewege12/03/2019Actions
Actions
Copy link

Also available in: Atom PDF