Bug #15921

[Workbench2] Remove spurious trailing slash from API endpoints

Added by Tom Clegg 7 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
12/10/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

For example, Workbench2 reportedly requests "POST /arvados/v1/collections/" when creating a new collection. The correct endpoint is "POST /arvados/v1/collections".


Subtasks

Task #15927: Review 15921-trailing-slash-fixResolvedPeter Amstutz


Related issues

Related to Arvados - Bug #15916: [controller] POST /arvados/v1/collections/ (with extra trailing slash) returns 404Rejected

Associated revisions

Revision 7c5a6b69
Added by Lucas Di Pentima 7 months ago

Merge branch '15921-trailing-slash-fix'
Closes #15921

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Tom Clegg 7 months ago

  • Related to Bug #15916: [controller] POST /arvados/v1/collections/ (with extra trailing slash) returns 404 added

#2 Updated by Peter Amstutz 7 months ago

  • Assigned To set to Lucas Di Pentima

#3 Updated by Lucas Di Pentima 7 months ago

  • Status changed from New to In Progress

#4 Updated by Lucas Di Pentima 7 months ago

Fix at commit 75ba9a3a (wb2 repo) - branch 15921-trailing-slash-fix

Trailing slashes were being added to every resource. Fixed that and updated the necessary calls to add the missing slash when needed.

#5 Updated by Lucas Di Pentima 7 months ago

Update at commit a908c393 fixes the api call made by the the link account service.

#6 Updated by Peter Amstutz 7 months ago

This came up originally trying to create a collection (although other stuff would have failed too).

I tried to create a collection and ran into another bug.

I fixed the bug and pushed commit:c055c90f752c104305e4097a9b7b5d029615e08f

This LGTM.

#7 Updated by Lucas Di Pentima 7 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF