Project

General

Profile

Actions

Story #15922

closed

Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)

Added by Tom Clegg over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
12/12/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #15923: Review 15922-force-legacy-api-14ResolvedTom Clegg12/12/2019

Actions

Related issues

Related to Arvados - Story #14287: [Controller] Refactor API code / routingResolvedTom Clegg06/18/2019

Actions
Actions #1

Updated by Tom Clegg over 2 years ago

  • Related to Story #14287: [Controller] Refactor API code / routing added
Actions #2

Updated by Tom Clegg over 2 years ago

  • Subject changed from Change EnableBetaController14287 (default false) to ForceRailsAPI (default false) to Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)
Actions #3

Updated by Tom Clegg over 2 years ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg
Actions #4

Updated by Tom Clegg over 2 years ago

15922-force-legacy-api-14 @ commit:eb3ff279c7f29745ff9a9a48288ef07731c812a9 -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1692/

Actions #6

Updated by Lucas Di Pentima over 2 years ago

Just a couple of comments, otherwise LGTM:

  • Should the controller log a warning when the flag is true reminding the admin that will be deprecated?
  • Do you think adding a test for existence of writable_by on responses would be useful? Asking because etag got one but I believe the other didn’t.
Actions #7

Updated by Tom Clegg over 2 years ago

I'm reluctant to warn about something the admin had to do explicitly after (presumably) reading the caveats in the config file comment. The config loader will warn automatically ("unknown config key") if it's still in the config when the flag is removed/unsupported.

Yes to a writable_by test. Added to 15922-force-legacy-api-14 @ 1c4a2d386dc0d2a85c86171801c6681d76fb12fe

Actions #8

Updated by Tom Clegg over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF