Story #15922

Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)

Added by Tom Clegg 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
12/12/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release relationship:
Auto

Subtasks

Task #15923: Review 15922-force-legacy-api-14ResolvedTom Clegg


Related issues

Related to Arvados - Story #14287: [Controller] Refactor API code / routingResolved06/18/2019

Associated revisions

Revision 8eda8735
Added by Tom Clegg 9 months ago

Merge branch '15922-force-legacy-api-14'

refs #15922

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Tom Clegg 10 months ago

  • Related to Story #14287: [Controller] Refactor API code / routing added

#2 Updated by Tom Clegg 10 months ago

  • Subject changed from Change EnableBetaController14287 (default false) to ForceRailsAPI (default false) to Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)

#3 Updated by Tom Clegg 10 months ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

#4 Updated by Tom Clegg 10 months ago

15922-force-legacy-api-14 @ commit:eb3ff279c7f29745ff9a9a48288ef07731c812a9 -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1692/

#6 Updated by Lucas Di Pentima 9 months ago

Just a couple of comments, otherwise LGTM:

  • Should the controller log a warning when the flag is true reminding the admin that will be deprecated?
  • Do you think adding a test for existence of writable_by on responses would be useful? Asking because etag got one but I believe the other didn’t.

#7 Updated by Tom Clegg 9 months ago

I'm reluctant to warn about something the admin had to do explicitly after (presumably) reading the caveats in the config file comment. The config loader will warn automatically ("unknown config key") if it's still in the config when the flag is removed/unsupported.

Yes to a writable_by test. Added to 15922-force-legacy-api-14 @ 1c4a2d386dc0d2a85c86171801c6681d76fb12fe

#8 Updated by Tom Clegg 9 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF