Arvados

Fixes at commit 88ab5c4388e8bbe9dfa29ef5fff653a511d3096b - branch 15951-filter-ui-polish
Test run: developer-tests-workbench2: #17

• Filter options (either checkboxes or radio buttons) are now selected when clicking anywhere on their row
• Filters that only allow 1 selected option don't present the ok/cancel buttons, and auto-submits on click.
• Tooltip doesn't keep on display after dismissing the filter popover dialog.
• Removed code that wasn't being used and adapted tests to work with the code that is actually being used.

I believe that there're some simplification opportunities on the Tree component but as it's something used on lots of places and the test suite isn't complete, I preferred to stop fiddling with the code at the moment.

Thanks! It is a small thing but it is a nice improvement.

A couple other details I noticed on the projects panel, hopefully easy to fix:

• The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
• The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Something I also thought of, that should probably go into another ticket:

• When you select which types of objects to show, it should hide the columns that don't make sense for any of the selected object types (eg if you are only looking processes, you don't need "file size").
• Should move the "types" column over to the left so the column content are the icons and there's no text.

Peter Amstutz wrote:

A couple other details I noticed on the projects panel, hopefully easy to fix:

• The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
• The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Fixed at commit e3a0a85e.

Something I also thought of, that should probably go into another ticket:

• When you select which types of objects to show, it should hide the columns that don't make sense for any of the selected object types (eg if you are only looking processes, you don't need "file size").
• Should move the "types" column over to the left so the column content are the icons and there's no text.

I'll add these to the wb2 feedback pile. Thanks!

Lucas Di Pentima wrote:

Peter Amstutz wrote:

A couple other details I noticed on the projects panel, hopefully easy to fix:

• The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
• The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Fixed at commit e3a0a85e.

This LGTM, thanks!