Bug #15951

Process filtering UI polish

Added by Peter Amstutz 9 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
03/04/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

The Subprocess data table:

In the "Status filters" popup, clicking on the button works to change the filter. However moving the mouse cursor over the text of an item and clicking it changes the item background but doesn't change the filter. Also it seems unnecessary to select the filter and then separately choose Ok/Cancel, a single click should select the item and close the dialog.

After closing the "Status filters" popup, the "Filters" tooltip remains on the screen, partly obscuring the first row.


Subtasks

Task #15967: Review 15951-filter-ui-polishResolvedPeter Amstutz


Related issues

Related to Arvados Workbench 2 - Bug #15672: List of subprocesses limited in process viewResolved12/16/2019

Associated revisions

Revision 9e38e058
Added by Lucas Di Pentima 7 months ago

Merge branch '15951-filter-ui-polish'. Closes #15951

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 9 months ago

  • Related to Bug #15672: List of subprocesses limited in process view added

#3 Updated by Peter Amstutz 9 months ago

  • Category set to Workbench2
  • Subject changed from [WB2] Process filtering UI polish to Process filtering UI polish

#4 Updated by Peter Amstutz 9 months ago

  • Assigned To set to Peter Amstutz

#5 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2020-01-15 Sprint to 2020-01-29 Sprint

#6 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2020-01-29 Sprint to 2020-02-12 Sprint

#7 Updated by Peter Amstutz 8 months ago

  • Assigned To changed from Peter Amstutz to Lucas Di Pentima

#8 Updated by Peter Amstutz 8 months ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint

#9 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2020-02-26 Sprint to 2020-03-11 Sprint

#10 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2020-03-11 Sprint to 2020-03-25 Sprint

#11 Updated by Lucas Di Pentima 7 months ago

  • Status changed from New to In Progress

#12 Updated by Lucas Di Pentima 7 months ago

Fixes at commit 88ab5c4388e8bbe9dfa29ef5fff653a511d3096b - branch 15951-filter-ui-polish
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/17/

  • Filter options (either checkboxes or radio buttons) are now selected when clicking anywhere on their row
  • Filters that only allow 1 selected option don't present the ok/cancel buttons, and auto-submits on click.
  • Tooltip doesn't keep on display after dismissing the filter popover dialog.
  • Removed code that wasn't being used and adapted tests to work with the code that is actually being used.

I believe that there're some simplification opportunities on the Tree component but as it's something used on lots of places and the test suite isn't complete, I preferred to stop fiddling with the code at the moment.

#13 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2020-03-25 Sprint to 2020-03-11 Sprint

#14 Updated by Peter Amstutz 7 months ago

Thanks! It is a small thing but it is a nice improvement.

A couple other details I noticed on the projects panel, hopefully easy to fix:

  • The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
  • The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Something I also thought of, that should probably go into another ticket:

  • When you select which types of objects to show, it should hide the columns that don't make sense for any of the selected object types (eg if you are only looking processes, you don't need "file size").
  • Should move the "types" column over to the left so the column content are the icons and there's no text.

#15 Updated by Lucas Di Pentima 7 months ago

Peter Amstutz wrote:

A couple other details I noticed on the projects panel, hopefully easy to fix:
  • The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
  • The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Fixed at commit e3a0a85e.

Something I also thought of, that should probably go into another ticket:
  • When you select which types of objects to show, it should hide the columns that don't make sense for any of the selected object types (eg if you are only looking processes, you don't need "file size").
  • Should move the "types" column over to the left so the column content are the icons and there's no text.

I'll add these to the wb2 feedback pile. Thanks!

#16 Updated by Peter Amstutz 7 months ago

Lucas Di Pentima wrote:

Peter Amstutz wrote:

A couple other details I noticed on the projects panel, hopefully easy to fix:
  • The hamburger menu in the upper-right has a tooltip "filters" but should be something like "select columns"
  • The "filters" tooltip has the same problem of remaining active after the user has closed the menu

Fixed at commit e3a0a85e.

This LGTM, thanks!

#17 Updated by Lucas Di Pentima 7 months ago

  • Status changed from In Progress to Resolved

#18 Updated by Peter Amstutz 6 months ago

  • Release set to 30

Also available in: Atom PDF