Arvados » Arvados Workbench 2

Reviewing 16005-allow-opening-projects-and-collections-in-new-tab @ arvados-workbench2|85a89af1e635a1f791eaf5ee68cb31552f23bd1a

The basic "open in new tab" functionality seems to work for projects and collections.

The story description included a "copy link to clipboard" feature which is missing from this branch.(1

The current approach feels awkward. When I tried it, the new tab loads, flickers, shows a spinner, flickers, and then finally shows the correct panel, and this all takes 5 or more seconds. It isn't a good user experience

In openInNewTabAction() I don't understand why it needs to do

storeRedirects(url);
window.open(window.location.origin, '_blank');

Why can't it just do something like:

window.open(url, '_blank');

I also don't understand the benefit of saving the redux state to local store. If it allowed the new tab to use cached data from the original state object that might make sense but it doesn't seem like it is happening here.

If I open a new tab, it should already be able to get the token from local storage (there's an apiToken entry), so it doesn't need the whole redux state.

However, if we are using session storage to hold the token more securely (so it does not persist after the tab is closed) then we need to be able to hand it off to the new tab. This was actually one of the motivations for this story. An easy thing would be to do this:

url = `/collections/${uuid}?api_token=${token}`;

This would require checking for and removing the "api_token" parameter from the URL bar, but I think we had already talked about doing this.

I had also put a link in the description to another strategy that uses a 'storage' event to communicate between tabs, which avoids flickering the token on screen: https://blog.guya.net/2015/06/12/sharing-sessionstorage-between-tabs-for-secure-multi-tab-authentication/

The last thing I noticed, the order of the items in the project and collection context menus is inconsistent, which is pretty confusing:

Applied in changeset arvados:arvados-workbench2|d5b2ea063f46c087ddbfb53ccfc066ecba209c7f.