Project

General

Profile

Actions
Copy link

Bug #16037

closed

"Download selected" functionality messes up file names

Added by Moritz Gilsdorf over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Daniel Kutyła
Category:
Workbench2
Target version:
Arvados - 2020-10-21 Sprint
Story points:
-
Release:
Arvados 2.1.1
Release relationship:
Auto

Description

When downloading all files at once from a collection we noticed that content of the files wasn't what it was supposed to be based on the file name. This is not the case when opening the file directly or from a arv-mount soit must be whatever is creating the ZIP file that is causing this issue.

e.g. we had a collection with gct files and for each of the gct files a txt/csv file. The content of these files is verified correct (e.g using the mount). When downloading all the files from workbench2 a zip file is produced where the gct files contain the content of the text files and vice versa.

Subtasks 1 (0 open — 1 closed)

Arvados - Task #16878: Review 16037-download-selected-functionality-messes-up-file-namesResolvedDaniel Kutyła10/07/2020Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 4 years ago

  • Release set to 20
Actions
Copy link
 #2

Updated by Moritz Gilsdorf over 3 years ago

  • Priority changed from Normal to Urgent
Actions
Copy link
 #3

Updated by Peter Amstutz over 3 years ago

  • Release deleted (20)
  • Target version set to 2020-10-07 Sprint
Actions
Copy link
 #4

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Daniel Kutyła
  • Subject changed from "Download selected" functionality messes up file names to "Download selected" functionality messes up file names
Actions
Copy link
 #6

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-10-07 Sprint to 2020-10-21 Sprint
Actions
Copy link
 #8

Updated by Lucas Di Pentima over 3 years ago

  • Based on what was reported on the ticket, I tried creating a new collection with text files and what I got after selecting all files and clicking on “download selected” is a zip file with the text files with names changed. That is to say: contents were there, but filenames were interchanged between them.
  • Then, I tried uploading a 99KB jpeg file, this file can be correctly downloaded by right-clicking on it and selecting “Download”. But when being selected and clicking “download selected”, the produced zip contains a 177KB file of “something” that’s not a jpeg file.
Actions
Copy link
 #10

Updated by Lucas Di Pentima over 3 years ago

  • The download action in file src/views-components/context-menu/action-sets/collection-files-item-action-set.ts shouldn’t be commented out because it’s for single file downloads, something that is working correctly AFAICT.
  • The commented code on the other file could have a brief explanation of why it’s currently in that state.
  • With that, it LGTM.
Actions
Copy link
 #12

Updated by Lucas Di Pentima over 3 years ago

Updates LGTM, please merge.

Actions
Copy link
 #13

Updated by Daniel Kutyła over 3 years ago

Temporary disabled the feature as it should be done on the backend to handle all file types

Actions
Copy link
 #14

Updated by Daniel Kutyła over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions
Copy link
 #15

Updated by Peter Amstutz over 3 years ago

  • Release set to 36
Actions
Copy link

Also available in: Atom PDF