Bug #16037
closed
"Download selected" functionality messes up file names
Added by Moritz Gilsdorf almost 5 years ago.
Updated about 4 years ago.
Release relationship:
Auto
Description
When downloading all files at once from a collection we noticed that content of the files wasn't what it was supposed to be based on the file name. This is not the case when opening the file directly or from a arv-mount soit must be whatever is creating the ZIP file that is causing this issue.
e.g. we had a collection with gct files and for each of the gct files a txt/csv file. The content of these files is verified correct (e.g using the mount). When downloading all the files from workbench2 a zip file is produced where the gct files contain the content of the text files and vice versa.
- Priority changed from Normal to Urgent
- Release deleted (
20)
- Target version set to 2020-10-07 Sprint
- Assigned To set to Daniel Kutyła
- Subject changed from "Download selected" functionality messes up file names to "Download selected" functionality messes up file names
- Status changed from New to In Progress
- Target version changed from 2020-10-07 Sprint to 2020-10-21 Sprint
- Based on what was reported on the ticket, I tried creating a new collection with text files and what I got after selecting all files and clicking on “download selected” is a zip file with the text files with names changed. That is to say: contents were there, but filenames were interchanged between them.
- Then, I tried uploading a 99KB jpeg file, this file can be correctly downloaded by right-clicking on it and selecting “Download”. But when being selected and clicking “download selected”, the produced zip contains a 177KB file of “something” that’s not a jpeg file.
- The download action in file
src/views-components/context-menu/action-sets/collection-files-item-action-set.ts
shouldn’t be commented out because it’s for single file downloads, something that is working correctly AFAICT.
- The commented code on the other file could have a brief explanation of why it’s currently in that state.
- With that, it LGTM.
Updates LGTM, please merge.
Temporary disabled the feature as it should be done on the backend to handle all file types
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Also available in: Atom
PDF