Bug #16039

FUSE respects ForwardSlashNameSubstitution

Added by Peter Amstutz 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/11/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #16095: Review 16039-fuse-forward-slash-subResolvedPeter Amstutz

Associated revisions

Revision 48c38895
Added by Tom Clegg about 2 months ago

Merge branch '16039-fuse-forward-slash-sub'

fixes #16039

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz 2 months ago

  • Assigned To set to Tom Clegg

#2 Updated by Tom Clegg about 2 months ago

  • Status changed from New to In Progress

#4 Updated by Peter Amstutz about 2 months ago

Tom Clegg wrote:

16039-fuse-forward-slash-sub @ 487e8f756d63c6e68eb300a559eccb504f78c40b -- https://ci.arvados.org/view/Developer/job/developer-run-tests/1723/

If you run this against a pre-2.0 server it runs into trouble because there's no public config endpoint in 1.4.

It doesn't crash on mount, but when you do ask for a directory listing where a name has a slash, you get an I/O error, because fetching from the config endpoint is deferred until first use.

Arv-mount should either fail gracefully (don't support older versions) or (preferably) have a fallback behavior (substitute '_' like it did before).

#5 Updated by Peter Amstutz about 2 months ago

2nd comment, it looks like SlashSubstitutionTest checks that writing to path that's been rewritten for ForwardSlashNameSubstitution doesn't fail, but it doesn't verify that it actually wrote to the correct collection. It should check that self.testcoll actually has a 'waz' file. Also 'foo-bar-baz' and 'foo/bar/baz' should have different file contents (to check that they arn't being confused for one another).

#6 Updated by Tom Clegg about 2 months ago

16039-fuse-forward-slash-sub @ c7cd69df4727d7e3ea6469c94a905465a2dcdd47 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/1727/
  • adds test for name conflict case (which was broken... and is fixed)
  • falls back to old behavior (replace with "_") if apiserver has no config endpoint, or FSNS entry is missing

#7 Updated by Tom Clegg about 2 months ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint

#8 Updated by Tom Clegg about 2 months ago

16039-fuse-forward-slash-sub @ a4f57793d8757c451330e6d861eb3c5af2bff3b8 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/1730/
  • Touches various setup.py to work around dependency bug #16151

#9 Updated by Peter Amstutz about 2 months ago

Tom Clegg wrote:

16039-fuse-forward-slash-sub @ a4f57793d8757c451330e6d861eb3c5af2bff3b8 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/1730/
  • Touches various setup.py to work around dependency bug #16151

LGTM.

#10 Updated by Anonymous about 2 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#11 Updated by Peter Amstutz about 1 month ago

  • Release set to 29

Also available in: Atom PDF