Project

General

Profile

Actions

Bug #16039

closed

FUSE respects ForwardSlashNameSubstitution

Added by Peter Amstutz over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #16095: Review 16039-fuse-forward-slash-subResolvedPeter Amstutz02/11/2020Actions
Actions #1

Updated by Peter Amstutz about 4 years ago

  • Assigned To set to Tom Clegg
Actions #2

Updated by Tom Clegg about 4 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Peter Amstutz about 4 years ago

Tom Clegg wrote:

16039-fuse-forward-slash-sub @ 487e8f756d63c6e68eb300a559eccb504f78c40b -- developer-run-tests: #1723

If you run this against a pre-2.0 server it runs into trouble because there's no public config endpoint in 1.4.

It doesn't crash on mount, but when you do ask for a directory listing where a name has a slash, you get an I/O error, because fetching from the config endpoint is deferred until first use.

Arv-mount should either fail gracefully (don't support older versions) or (preferably) have a fallback behavior (substitute '_' like it did before).

Actions #5

Updated by Peter Amstutz about 4 years ago

2nd comment, it looks like SlashSubstitutionTest checks that writing to path that's been rewritten for ForwardSlashNameSubstitution doesn't fail, but it doesn't verify that it actually wrote to the correct collection. It should check that self.testcoll actually has a 'waz' file. Also 'foo-bar-baz' and 'foo/bar/baz' should have different file contents (to check that they arn't being confused for one another).

Actions #6

Updated by Tom Clegg about 4 years ago

16039-fuse-forward-slash-sub @ c7cd69df4727d7e3ea6469c94a905465a2dcdd47 -- developer-run-tests: #1727
  • adds test for name conflict case (which was broken... and is fixed)
  • falls back to old behavior (replace with "_") if apiserver has no config endpoint, or FSNS entry is missing
Actions #7

Updated by Tom Clegg about 4 years ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint
Actions #8

Updated by Tom Clegg about 4 years ago

16039-fuse-forward-slash-sub @ a4f57793d8757c451330e6d861eb3c5af2bff3b8 -- developer-run-tests: #1730
  • Touches various setup.py to work around dependency bug #16151
Actions #9

Updated by Peter Amstutz about 4 years ago

Tom Clegg wrote:

16039-fuse-forward-slash-sub @ a4f57793d8757c451330e6d861eb3c5af2bff3b8 -- developer-run-tests: #1730
  • Touches various setup.py to work around dependency bug #16151

LGTM.

Actions #10

Updated by Anonymous about 4 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #11

Updated by Peter Amstutz about 4 years ago

  • Release set to 29
Actions

Also available in: Atom PDF