Project

General

Profile

Actions

Bug #16041

closed

Client side validation disallows '/' in name even when configured to allow it

Added by Peter Amstutz over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/16/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks 1 (0 open1 closed)

Task #16042: Review 16041-valid-nameResolvedPeter Amstutz01/16/2020

Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Assigned To set to Peter Amstutz
Actions #2

Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Lucas Di Pentima over 2 years ago

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

  • The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
  • Other than that, it LGTM.
Actions #4

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

  • The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
  • Other than that, it LGTM.

Ok, the warning is now conditional on ForwardSlashNameSubstitution.

16041-valid-name @ commit:631d2a3780d7d6ae292dc4e5b8a277880e1ef2ca

Actions #5

Updated by Lucas Di Pentima over 2 years ago

Works great! LGTM, thanks!

Actions #6

Updated by Peter Amstutz over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF