Bug #16041

Client side validation disallows '/' in name even when configured to allow it

Added by Peter Amstutz over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/16/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #16042: Review 16041-valid-nameResolvedPeter Amstutz

Associated revisions

Revision af2033d6
Added by Peter Amstutz over 1 year ago

Merge branch '16041-valid-name' refs #16041

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz over 1 year ago

  • Assigned To set to Peter Amstutz

#2 Updated by Peter Amstutz over 1 year ago

  • Status changed from New to In Progress

#3 Updated by Lucas Di Pentima over 1 year ago

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

  • The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
  • Other than that, it LGTM.

#4 Updated by Peter Amstutz over 1 year ago

Lucas Di Pentima wrote:

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

  • The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
  • Other than that, it LGTM.

Ok, the warning is now conditional on ForwardSlashNameSubstitution.

16041-valid-name @ commit:631d2a3780d7d6ae292dc4e5b8a277880e1ef2ca

#5 Updated by Lucas Di Pentima over 1 year ago

Works great! LGTM, thanks!

#6 Updated by Peter Amstutz over 1 year ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF