https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422020-01-16T21:11:07ZArvadosArvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809252020-01-16T21:11:07ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809262020-01-16T21:11:20ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809312020-01-17T03:54:46ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Reviewing branch <code>16041-valid-name</code> @ commit c29de73 (wb2 repo):</p>
<ul>
<li>The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.</li>
<li>Other than that, it LGTM.</li>
</ul> Arvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809372020-01-17T15:08:39ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Reviewing branch <code>16041-valid-name</code> @ commit c29de73 (wb2 repo):</p>
<ul>
<li>The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.</li>
<li>Other than that, it LGTM.</li>
</ul>
</blockquote>
<p>Ok, the warning is now conditional on ForwardSlashNameSubstitution.</p>
<p>16041-valid-name @ <a class="changeset" title="IllegalNamingWarning is conditional on ForwardSlashNameSubstitution Arvados-DCO-1.1-Signed-off-b..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/631d2a3780d7d6ae292dc4e5b8a277880e1ef2ca">631d2a3780d7d6ae292dc4e5b8a277880e1ef2ca</a></p> Arvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809422020-01-17T16:01:05ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Works great! LGTM, thanks!</p> Arvados - Bug #16041: Client side validation disallows '/' in name even when configured to allow ithttps://dev.arvados.org/issues/16041?journal_id=809452020-01-17T16:05:55ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul>