Arvados

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

• The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
• Other than that, it LGTM.

Lucas Di Pentima wrote:

Reviewing branch 16041-valid-name @ commit c29de73 (wb2 repo):

• The warning component doesn’t take into account the case when the slash char is allowd. Looking at the reworded warning message I suppose the idea is to show the warning even if the site admin configured a substitution, my opinion is that if the admin allows slashes is because they’re needed and so showing warnings on the UI would be confusing and/or annoying to users.
• Other than that, it LGTM.

Ok, the warning is now conditional on ForwardSlashNameSubstitution.

16041-valid-name @ 631d2a3780d7d6ae292dc4e5b8a277880e1ef2ca

Works great! LGTM, thanks!