Project

General

Profile

Actions

Story #16068

closed

[Process view] Process panel main view data

Added by Lucas Di Pentima over 2 years ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
04/12/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Merge the "Process info" and "process details" panels.

Use "ProcessDetailsAttributes" for both the right hand details and the info panel.

Update ProcessDetailsAttributes to include the following fields:

  • Name
  • UUID
  • Owner UUID (ResourceOwnerWithName)
  • Container status (queued, running, complete, failed) ("Locked" state should be rendered as "queued") this should continue to be rendered as a badge with color like it is now
  • User it ran as (this is "runtime_user_uuid" of the underlying container object) (ResourceOwnerWithName)
  • Create time
  • Start time
  • End time
  • Run time (or "now" if not done yet)
  • Link to output collection
  • Link to log collection
  • Link to docker image collection
  • Link to "requesting_container_uuid" (if non-null)
  • Properties

Things that should be displayed in separate, additional panels (will be separate stories):

  • Logs
  • Input collections
  • Command line
  • Runtime constraints / scheduling constraints / output storage class

(note: we might consider refactoring some of the fields currently listed in "details" into one of these other panels, but they have to be implemented first).


Subtasks 1 (0 open1 closed)

Task #18828: Review 16068-merge-process-info-details-panelsResolvedStephen Smith04/12/2022

Actions

Related issues

Related to Arvados - Story #16248: Propose redesign of process view based on feedbackResolvedLucas Di Pentima12/08/2021

Actions
Related to Arvados Epics - Story #16945: WB2 Workflows / containers feature parityIn Progress08/01/202107/31/2022

Actions
Actions #1

Updated by Lucas Di Pentima over 2 years ago

  • Related to Story #15333: Workbench2 feature parity with Workbench added
Actions #2

Updated by Lucas Di Pentima over 2 years ago

  • Subject changed from Run summary (start/stop time) to Process panel detailed information data
  • Run summary (start/stop time)
  • who it ran as
  • container uuid (it is being displayed as text)
  • runtime constraints (enhance display style?)
  • output_path is being displayed instead of output collection?
Actions #3

Updated by Lucas Di Pentima over 2 years ago

  • Description updated (diff)
  • Subject changed from Process panel detailed information data to Process panel main view data
Actions #4

Updated by Peter Amstutz over 2 years ago

  • Target version deleted (To Be Groomed)
Actions #5

Updated by Lucas Di Pentima over 2 years ago

  • Description updated (diff)
Actions #6

Updated by Lucas Di Pentima over 2 years ago

  • Release changed from 20 to 31
Actions #7

Updated by Peter Amstutz over 2 years ago

  • Category changed from Workbench2 to 0
  • Subject changed from Process panel main view data to [Process view] Process panel main view data
Actions #8

Updated by Peter Amstutz over 2 years ago

  • Category changed from 0 to Workbench2
Actions #9

Updated by Peter Amstutz over 1 year ago

  • Related to Story #16248: Propose redesign of process view based on feedback added
Actions #10

Updated by Peter Amstutz over 1 year ago

  • Related to Story #16945: WB2 Workflows / containers feature parity added
Actions #11

Updated by Peter Amstutz about 1 year ago

  • Related to deleted (Story #15333: Workbench2 feature parity with Workbench)
Actions #12

Updated by Peter Amstutz 5 months ago

  • Target version set to 2022-03-16 sprint
  • Assigned To set to Stephen Smith
  • Category deleted (Workbench2)
  • Description updated (diff)
  • Project changed from Arvados Workbench 2 to Arvados
Actions #13

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #14

Updated by Peter Amstutz 5 months ago

  • Release changed from 31 to 47
Actions #15

Updated by Peter Amstutz 5 months ago

  • Category set to Workbench2
Actions #16

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
Actions #17

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-03-30 Sprint to 2022-04-13 Sprint
Actions #18

Updated by Stephen Smith 4 months ago

  • Status changed from New to In Progress
Actions #19

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|444c41ca81c90ff172c7b1d99ff78f52bff991e8 branch 16068-merge-process-info-details-panels
Tests developer-tests-workbench2: #659

  • Merged the 2 panels contents, removed info panel
  • Added cypress waitForDom helper to reduce test flakiness
Actions #21

Updated by Peter Amstutz 4 months ago

  • Release changed from 47 to 51
  • Target version changed from 2022-04-13 Sprint to 2022-04-27 Sprint
Actions #22

Updated by Lucas Di Pentima 4 months ago

Some initial comments:

  • The process' status already is shown in the main UI as a badge.
  • "Properties", "Requesting Container UUID" and "Run time" are missing.
  • The "Type" field seems superfluous on the main process UI.
  • I think we should skip the "Runtime constraints" data as it'll be implemented in a separate story (as per this story's comment).
  • For UI consistency's sake, I think we should try to match the properties' ordering as much as possible with what we have on the collections UI: For example: The resource's and owner's UUIDs could be at the very top.
  • Please check that the "Expires At" field is really used, if what's on our doc page (https://doc.arvados.org/v2.4/api/methods/container_requests.html) is correct, it isn't implemented yet so we can skip it.
  • The "Outputs: /var/spool/cwl" field doesn't seem useful. Could you instead place the output collection's link as its value?
  • The "Last modified" field seems useless to me, and it's not listed as a requirement nor used in wb1, so I think we could skip it. (Please double check with Peter)

As commented on video chat: Type and Status may not be rendered on the main Process' UI but should when used on the details right-hand side panel, so we may need some kind of switch to turn those on/off.

Actions #23

Updated by Stephen Smith 4 months ago

Updates at arvados-workbench2|1bb147efcf6a17c0b4237c790757dd54994005b2
tests developer-tests-workbench2: #669 /console

  • Made type and status only show on process panel
  • Added properties, requesting container uuid, runtime
  • Removed constraints, expires, last modified, and extraneous outputs field
  • Reordered fields to be similar to collections
  • added
    controllerURL=`echo "$controllerInfo" | awk '{print $1;}'`;
    

    to integration script to get only first token of arvboot output (https://localhost:35219/ zzzzz localhost:35219)
Actions #24

Updated by Lucas Di Pentima 4 months ago

This is looking great! Just one remaining observation:

  • On the right-side details panel, the displayed "Status" attribute should be the same as the status badge on the main UI instead of the container's request "State" field. (the process status is derived from both container request & container states -- you can use getProcessStatus() to get it)

The rest LGTM, thanks!

Actions #25

Updated by Stephen Smith 4 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF