Project

General

Profile

Actions

Bug #16086

closed

always says "There are no inputs" when trying display inputs to a process

Added by Peter Amstutz over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/27/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-


Subtasks 1 (0 open1 closed)

Task #16088: Review 16086-no-inputs-fixResolvedPeter Amstutz01/27/2020

Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Subject changed from always says "There are no inputs" when trying to display inputs to always says "There are no inputs" when trying display inputs to a process
Actions #2

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #3

Updated by Lucas Di Pentima over 2 years ago

  • Assigned To set to Lucas Di Pentima
  • Status changed from New to In Progress
Actions #4

Updated by Lucas Di Pentima over 2 years ago

Updates at commit 874af8e3 - branch 16086-no-inputs-fix

Fixed an error I made on commit c5fa0c4eed while working on #15407.
Also fixed an issue when displaying start/finish dates.

Actions #5

Updated by Peter Amstutz over 2 years ago

Now when I try to select "inputs" I get a crash page:

TypeError: values.map is not a function
./src/components/chips/chips.tsx/Chips.prototype.render
src/workbench2/src/components/chips/chips.tsx:32

  29 | render() {
  30 |     const { values, filler } = this.props;
  31 |     return <Grid container spacing={8} className={this.props.classes.root}>
> 32 |         {values.map(this.renderChip)}
  33 |         {filler && <Grid item xs>{filler}</Grid>}
  34 |     </Grid>;
  35 | }
Actions #7

Updated by Peter Amstutz over 2 years ago

ce8i5-xvhdp-y7wg0hr7pqo7m3t has the same input shape except the list isn't empty

Actions #8

Updated by Lucas Di Pentima over 2 years ago

Updates at commit cb148df5 ready for review.

Actions #9

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2020-02-12 Sprint to 2020-01-29 Sprint
Actions #10

Updated by Peter Amstutz over 2 years ago

value: data.mounts[MOUNT_PATH_CWL_INPUT].content[it.id.split('#main/')[1]] || [],

That's not quite right. You should split on '/' and then take the last element.

Actions #11

Updated by Lucas Di Pentima over 2 years ago

Fixed at commit a94a57d2, thanks!

Actions #12

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

Fixed at commit a94a57d2, thanks!

Now that it works I see the existing user interface is a little weird but that's a separate story, this LGTM!

Actions #13

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF