Bug #16101

https://ce8i5.arvadosapi.com/users/sign_out path not found

Added by Peter Amstutz 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Login
Target version:
Start date:
02/18/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When using Controller's native Google login, logging out results in an error.


Subtasks

Task #16149: Review 16101-logoutResolvedPeter Amstutz

Associated revisions

Revision feb29006
Added by Tom Clegg about 1 month ago

Merge branch '16101-logout'

fixes #16101

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz 2 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 2 months ago

  • Category set to Login

#3 Updated by Peter Amstutz 2 months ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint

#4 Updated by Tom Clegg 2 months ago

Controller needs a Logout() method that bypasses railsProxy when Login.GoogleClientID is configured, similar to Login() in source:lib/controller/localdb/conn.go. The native implementation doesn't set cookies so I think this is a no-op, just redirecting to the return_to param value (or if none provided, workbench2?).

#5 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2020-02-26 Sprint to 2020-03-11 Sprint

#6 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2020-03-11 Sprint to 2020-02-26 Sprint

#7 Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Tom Clegg

#8 Updated by Tom Clegg about 2 months ago

  • Status changed from New to In Progress

#10 Updated by Peter Amstutz about 1 month ago

Tom Clegg wrote:

16101-logout @ e459f4e2d40762f67ffedafbe988c8da6f4f04d4 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/1736/

It looks like if return_to is unspecified you'll get a blank (invalid) redirect. The API server sends you to the API server root (return_to = params[:return_to] || root_url) but sending you to Workbench by default would probably be better.

#13 Updated by Anonymous about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#14 Updated by Peter Amstutz about 1 month ago

  • Release set to 29

Also available in: Atom PDF