Project

General

Profile

Actions
Copy link

Feature #16106

closed

[arvados-dispatch-cloud] Azure driver support for preemptible instances

Added by Tom Clegg about 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Ward Vandewege
Category:
Crunch
Target version:
2021-01-20 Sprint
Story points:
1.0
Release:
Arvados 2.1.2
Release relationship:
Auto

Description

When creating instances, source:lib/cloud/azure should create a preemptible instance if the instance type's Preemptible flag is set.

arvados-dispatch-cloud already knows how to choose a preemptible type if the container's scheduling_constraints want one; see ChooseInstanceType() in source:lib/dispatchcloud/node_size.go

Subtasks 1 (0 open — 1 closed)

Task #16960: Review 16106-azure-spot-instance-supportResolvedWard Vandewege01/07/2021Actions

Related issues

Related to Arvados - Idea #13908: [Epic] Replace SLURM for cloud job scheduling/dispatchingResolvedActions
Related to Arvados - Feature #17249: Make costanalyzer aware of preemptable instancesResolvedWard Vandewege02/04/2021Actions
Actions
Copy link
 #1

Updated by Tom Clegg about 4 years ago

  • Related to Idea #13908: [Epic] Replace SLURM for cloud job scheduling/dispatching added
Actions
Copy link
 #2

Updated by Ward Vandewege almost 4 years ago

  • Target version set to To Be Groomed
Actions
Copy link
 #3

Updated by Ward Vandewege almost 4 years ago

  • Target version deleted (To Be Groomed)
Actions
Copy link
 #4

Updated by Peter Amstutz over 3 years ago

  • Target version set to 2020-10-21 Sprint
Actions
Copy link
 #5

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint
Actions
Copy link
 #6

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-11-04 Sprint to 2020-10-21 Sprint
Actions
Copy link
 #7

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #8

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Ward Vandewege
Actions
Copy link
 #9

Updated by Ward Vandewege over 3 years ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint
Actions
Copy link
 #10

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-11-04 Sprint to 2020-11-18
Actions
Copy link
 #11

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-11-18 to 2020-12-02 Sprint
Actions
Copy link
 #12

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-12-02 Sprint to 2020-12-16 Sprint
Actions
Copy link
 #13

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-12-16 Sprint to 2021-01-06 Sprint
Actions
Copy link
 #14

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2021-01-06 Sprint to 2021-01-20 Sprint
Actions
Copy link
 #15

Updated by Ward Vandewege over 3 years ago

Ready for review at c1a84bf6f6c570cc632a5ba8c6406543e2206e3a on branch 16106-azure-spot-instance-support. In addition to the automated tests, also tested on ce8i5.

Actions
Copy link
 #16

Updated by Ward Vandewege over 3 years ago

  • Related to Feature #17249: Make costanalyzer aware of preemptable instances added
Actions
Copy link
 #17

Updated by Tom Clegg over 3 years ago

Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.

Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).

Rest LGTM. Thanks!

Actions
Copy link
 #18

Updated by Ward Vandewege over 3 years ago

Tom Clegg wrote:

Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.

Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).

Rest LGTM. Thanks!

Great, nice catch, both changes made, and merged.

Actions
Copy link
 #19

Updated by Ward Vandewege over 3 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #20

Updated by Ward Vandewege about 3 years ago

  • Release set to 37
Actions
Copy link

Also available in: Atom PDF