Feature #16106

[arvados-dispatch-cloud] Azure driver support for preemptible instances

Added by Tom Clegg over 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Ward Vandewege
Category:
Crunch
Target version:
2021-01-20 Sprint
Start date:
01/07/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Arvados 2.1.2
Release relationship:
Auto

Description

When creating instances, source:lib/cloud/azure should create a preemptible instance if the instance type's Preemptible flag is set.

arvados-dispatch-cloud already knows how to choose a preemptible type if the container's scheduling_constraints want one; see ChooseInstanceType() in source:lib/dispatchcloud/node_size.go

Subtasks

Task #16960: Review 16106-azure-spot-instance-supportResolvedWard Vandewege

Related issues

Related to Arvados - Story #13908: [Epic] Replace SLURM for cloud job scheduling/dispatchingResolved

Related to Arvados - Feature #17249: Make costanalyzer aware of preemptable instancesResolved02/04/2021

Associated revisions

Revision 2df04c08
Added by Ward Vandewege over 1 year ago

Merge branch '16106-azure-spot-instance-support'

closes #16106

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Tom Clegg over 2 years ago

  • Related to Story #13908: [Epic] Replace SLURM for cloud job scheduling/dispatching added

#2 Updated by Ward Vandewege almost 2 years ago

  • Target version set to To Be Groomed

#3 Updated by Ward Vandewege almost 2 years ago

  • Target version deleted (To Be Groomed)

#4 Updated by Peter Amstutz over 1 year ago

  • Target version set to 2020-10-21 Sprint

#5 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint

#6 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-11-04 Sprint to 2020-10-21 Sprint

#7 Updated by Peter Amstutz over 1 year ago

  • Status changed from New to In Progress

#8 Updated by Peter Amstutz over 1 year ago

  • Assigned To set to Ward Vandewege

#9 Updated by Ward Vandewege over 1 year ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint

#10 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-11-04 Sprint to 2020-11-18

#11 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-11-18 to 2020-12-02 Sprint

#12 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-12-02 Sprint to 2020-12-16 Sprint

#13 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-12-16 Sprint to 2021-01-06 Sprint

#14 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2021-01-06 Sprint to 2021-01-20 Sprint

#15 Updated by Ward Vandewege over 1 year ago

Ready for review at c1a84bf6f6c570cc632a5ba8c6406543e2206e3a on branch 16106-azure-spot-instance-support. In addition to the automated tests, also tested on ce8i5.

#16 Updated by Ward Vandewege over 1 year ago

  • Related to Feature #17249: Make costanalyzer aware of preemptable instances added

#17 Updated by Tom Clegg over 1 year ago

Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.

Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).

Rest LGTM. Thanks!

#18 Updated by Ward Vandewege over 1 year ago

Tom Clegg wrote:

Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.

Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).

Rest LGTM. Thanks!

Great, nice catch, both changes made, and merged.

#19 Updated by Ward Vandewege over 1 year ago

  • Status changed from In Progress to Resolved

#20 Updated by Ward Vandewege over 1 year ago

  • Release set to 37

Also available in: Atom PDF