https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422020-02-07T18:46:42ZArvadosArvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=820332020-02-07T18:46:42ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Lucas Di Pentima</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=820422020-02-07T23:43:53ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Fix at <a class="changeset" title="16141: Adds missing collection fields to GoSDK. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/7d1970e46ed5dab65e1eaa28b3ddfe609ffe6e4e">7d1970e46</a> - branch <code>16141-gosdk-missing-fields</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/1720/"<a href="https://ci.arvados.org/job/developer-run-tests/1720/">developer-run-tests: #1720 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=1720" alt="" /></a></a></p>
<ul>
<li>Adds missing collection fields from the RailsAPI on the GoSDK.</li>
<li>Adds test comparing direct RailsAPI response against controller's.</li>
</ul>
<p>If this is the correct testing approach, we could expand it to the other object types.</p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=820452020-02-09T23:23:43ZTom Cleggtom@curii.com
<ul></ul><blockquote>
<p>If this is the correct testing approach, we could expand it to the other object types.</p>
</blockquote>
<p>Yes, this test (and expanding it to other types) looks like a good idea.</p>
<p>Why does the test avoid checking the controller response value when the Rails response value is nil? (Wouldn't the DeepEquals check still be fitting in this case?)</p>
<p>While we're here, does the converse test (new fields returned by controller that don't come from Rails) reveal anything interesting?</p>
<p>I don't think we should add "href". It seems to be broken in railsAPI anyway, currently reporting "/collections/$uuid".</p>
<p>version, file_count, and file_size_total are all "not null" in the database, so they should be <code>int</code>, not <code>*int</code>.</p>
<p>file_size_total should probably be int64, like file sizes elsewhere in Go (e.g., <a class="external" href="https://golang.org/pkg/os/#FileInfo">https://golang.org/pkg/os/#FileInfo</a>).</p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=821802020-02-10T18:03:43ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="16141: Fixes GoSDK's User type. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentim..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/ebd4760f06f66fa31ea72aaed817094a36ca5ab8">ebd4760f0</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/1722/"<a href="https://ci.arvados.org/job/developer-run-tests/1722/">developer-run-tests: #1722 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=1722" alt="" /></a></a></p>
<ul>
<li>Addresses above suggestions ignoring the <code>href</code> field, and fixing some <code>Collection</code> type's field declarations.</li>
<li>Expands test case to check for other object types.</li>
<li>Fixes <code>User</code>'s fixture and GoSDK type.</li>
</ul> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=821822020-02-10T19:05:44ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Added better failure message on <a class="changeset" title="16141: Adds better message on test in failing situations. Arvados-DCO-1.1-Signed-off-by: Lucas D..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/1da59913e052cd419c4e43b4c7c6f569a94851bd">1da59913e</a></p>
<p>It seems that the <code>keep_services</code>' fixture is not loaded when running tests on Jenkins? The tests pass on my local dev env: <a class="external" href="https://ci.arvados.org/job/developer-run-tests-remainder/1789/console"<a href="https://ci.arvados.org/job/developer-run-tests-remainder/1789/">developer-run-tests-remainder: #1789 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-remainder&build=1789" alt="" /></a>/console</a></p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=821842020-02-10T19:25:06ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Fix on <a class="changeset" title="16141: Fixes test to use the 1st keep_service's uuid the test server returns. Arvados-DCO-1.1-Si..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/484cf9fec8734bc465b7d90cdfc26e1437d402cf">484cf9fec</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests-remainder/1790/"<a href="https://ci.arvados.org/job/developer-run-tests-remainder/1790/">developer-run-tests-remainder: #1790 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-remainder&build=1790" alt="" /></a></a></p>
<ul>
<li>Instead of using a <code>keep_service</code> fixture UUID, request the list of keep services to the test server and use the first.</li>
</ul> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=821962020-02-11T16:15:55ZTom Cleggtom@curii.com
<ul></ul><p>Although description can be null in the database, null vs. "" doesn't seem like a meaningful distinction -- it can be a string rather than a *string.</p>
<p>Is there a reason why collection Version, user ModifiedByClientUUID, and user ModifiedByUserUUID need to be pointers? Database says "not null".</p>
<p>(Doesn't need to be changed, just fyi) you could have used nil instead of map[string]bool{} for all the empty maps in the test case, since nobody assigns to them.</p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=821992020-02-11T16:43:05ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="16141: Updates the test to use a different, more complete collection fixture. Arvados-DCO-1.1-Si..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/64dc3f43d2ab72bad15e2da912adf970ad23182b">64dc3f43d</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests-remainder/1792/"<a href="https://ci.arvados.org/job/developer-run-tests-remainder/1792/">developer-run-tests-remainder: #1792 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-remainder&build=1792" alt="" /></a></a></p>
<ul>
<li>Fixed the Collection type.</li>
<li>Updated the test to use a more complete collection fixture.</li>
</ul> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=822012020-02-11T16:44:42ZTom Cleggtom@curii.com
<ul></ul><p>LGTM, thanks!</p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=822122020-02-11T17:13:54ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Checking the merge commit previous to push, I realized I forgot to correct the User type, so I've just did that and also added the <code>modified_by_*_uuid</code> fields to the active user fixture, because the only one that had those fields was the System user, but it lacks of other fields.</p>
<p>Updates at <a class="changeset" title="16141: Fixes User type, adjusts fixture to make the test pass. Arvados-DCO-1.1-Signed-off-by: Lu..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/785bed2f78d228cd3e203c25b0f4484f1c53be6d">785bed2f7</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/1724/"<a href="https://ci.arvados.org/job/developer-run-tests/1724/">developer-run-tests: #1724 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=1724" alt="" /></a></a></p> Arvados - Bug #16141: [controller] Missing collection's new fields on responseshttps://dev.arvados.org/issues/16141?journal_id=822132020-02-11T18:30:24ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul>