Project

General

Profile

Actions

Bug #16144

closed

container_request missing nil checks

Added by Peter Amstutz over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
02/11/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

1. in models/container_request.rb#update_collections

manifest = Collection.where(portable_data_hash: pdh).first.manifest_text

Fails if pdh is non-nil but not found.

2. in models/container_request.rb#finalize_if_needed

      c = Container.find_by_uuid(container_uuid)
      c.lock!

Fails if container_uuid is not found.

Also, if the container_request is being destroyed, finalize_if_needed should be skipped. (It is an after_save hook, do those run on destroy?)


Subtasks 1 (0 open1 closed)

Task #16145: Review 16144-nil-checksResolvedPeter Amstutz02/11/2020

Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz over 2 years ago

  • Priority changed from Normal to High
  • Description updated (diff)
Actions #3

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #4

Updated by Lucas Di Pentima over 2 years ago

  • Release set to 22
  • Assigned To set to Lucas Di Pentima
  • Category set to API
Actions #5

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #6

Updated by Lucas Di Pentima over 2 years ago

Fixes at cf0171de6 - branch 16144-nil-checks
Test run: developer-run-tests: #1725

Actions #7

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

Fixes at cf0171de6 - branch 16144-nil-checks
Test run: developer-run-tests: #1725

LGTM, thanks!

Actions #8

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF