Actions
Bug #16144
closed
container_request missing nil checks
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
1. in models/container_request.rb#update_collections
manifest = Collection.where(portable_data_hash: pdh).first.manifest_text
Fails if pdh is non-nil but not found.
2. in models/container_request.rb#finalize_if_needed
c = Container.find_by_uuid(container_uuid)
c.lock!
Fails if container_uuid is not found.
Also, if the container_request is being destroyed, finalize_if_needed should be skipped. (It is an after_save hook, do those run on destroy?)
Updated by Peter Amstutz almost 5 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz almost 5 years ago
- Priority changed from Normal to High
- Description updated (diff)
Updated by Lucas Di Pentima almost 5 years ago
- Release set to 22
- Assigned To set to Lucas Di Pentima
- Category set to API
Updated by Lucas Di Pentima almost 5 years ago
Fixes at cf0171de6 - branch 16144-nil-checks
Test run: developer-run-tests: #1725
Updated by Peter Amstutz almost 5 years ago
Lucas Di Pentima wrote:
Fixes at cf0171de6 - branch
16144-nil-checks
Test run: developer-run-tests: #1725
LGTM, thanks!
Updated by Lucas Di Pentima almost 5 years ago
- Status changed from In Progress to Resolved
Actions