Project

General

Profile

Actions

Idea #16243

closed

Filter files by name on collection’s file listing

Added by Lucas Di Pentima about 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

Useful for multi-select operations: being able to filter VCF files so can be selected in one click to create a new collection.


Subtasks 1 (0 open1 closed)

Arvados - Task #16766: Review 16243-filter-files-by-name-on-collections-file-listingResolvedDaniel Kutyła09/15/2020Actions

Related issues

Related to Arvados Epics - Idea #15333: Workbench2 feature parity with WorkbenchClosed01/01/202012/31/2021Actions
Actions #1

Updated by Lucas Di Pentima about 4 years ago

  • Related to Idea #15333: Workbench2 feature parity with Workbench added
Actions #2

Updated by Lucas Di Pentima about 4 years ago

  • Category changed from Workbench2 to Workbench2
  • Project changed from Arvados to Arvados Workbench 2
Actions #3

Updated by Peter Amstutz over 3 years ago

  • Target version set to 2020-08-12 Sprint
Actions #4

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
Actions #5

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint
Actions #6

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Daniel Kutyła
Actions #7

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-09-09 Sprint to 2020-09-23 Sprint
Actions #9

Updated by Lucas Di Pentima over 3 years ago

Reviewing 0c1fb93 - branch 16243-filter-files-by-name-on-collections-file-listing

Thanks, this is looking good! Some comments on my first tests:

  • On the search box I think it would be convenient to say “Search files” instead of “Search” only so it’s clear that only files are being filtered.
  • On wb1 I think we use regular expressions for filtering, let’s confirm with Peter if this would be needed on wb2 too.
  • When doing a search with partial results, then clicking on the “Select all” option at the hamburger menu and then clicking on some action like “create a new collection with selected”, not only the displayed items get copied but really all items in the collection. As described on the ticket, this would be one use case of the search feature.
Actions #11

Updated by Lucas Di Pentima over 3 years ago

Reviewing arvados-workbench2|0c00f9d

  • Commented code on src/store/collection-panel/collection-panel-files/collection-panel-files-reducer.ts line 30 should be removed
  • Can you write a test that confirms that “select all” works with the search feature?
  • I still have the same issue described on my previous note: Do a search, "select all” the filtered results, “create a new collection with selected” creates an exact collection with all files.
  • About the use of regex for searching: have you confirmed with Peter that they’re not needed?
Actions #13

Updated by Lucas Di Pentima over 3 years ago

Just one observation:

  • There’s commented out code left over at file src/store/collections/collection-partial-copy-actions.ts line 69

I've tested the "create new collection with selected" feature and sometimes it gave me an error, then I tried the rest of the operations with selected files and almost all have some kind of issues, I even tried the "remove selected" from ce8i5's wb2 and detected problems so I think these aren't related to the file filtering feature that we're attempting to introduce on this ticket. Will have to create a bug ticket for those (if it doesn't already exist).

So with that, it LGTM. Thanks.

Actions #14

Updated by Daniel Kutyła over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved
Actions

Also available in: Atom PDF