Arvados » Arvados Workbench 2

New version: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/0c1fb93d6aa22e4f3e7bd9b857b7b4e953d2f763
Test run: developer-tests-workbench2: #89

Added filtering in the collections view

Reviewing 0c1fb93 - branch 16243-filter-files-by-name-on-collections-file-listing

Thanks, this is looking good! Some comments on my first tests:

• On the search box I think it would be convenient to say “Search files” instead of “Search” only so it’s clear that only files are being filtered.
• On wb1 I think we use regular expressions for filtering, let’s confirm with Peter if this would be needed on wb2 too.
• When doing a search with partial results, then clicking on the “Select all” option at the hamburger menu and then clicking on some action like “create a new collection with selected”, not only the displayed items get copied but really all items in the collection. As described on the ticket, this would be one use case of the search feature.

New version: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/0c00f9d96076ad46e2ee499230f3f22a1603675d
Test run: developer-tests-workbench2: #90

Added reducer changes in order to make file download valid

Reviewing arvados-workbench2|0c00f9d

• Commented code on src/store/collection-panel/collection-panel-files/collection-panel-files-reducer.ts line 30 should be removed
• Can you write a test that confirms that “select all” works with the search feature?
• I still have the same issue described on my previous note: Do a search, "select all” the filtered results, “create a new collection with selected” creates an exact collection with all files.
• About the use of regex for searching: have you confirmed with Peter that they’re not needed?

New version: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/ffbfe1965a34800f933b20a32374d9cd9eb7ea72
Test run: developer-tests-workbench2: #92

Fixed copy of collection

Just one observation:

• There’s commented out code left over at file src/store/collections/collection-partial-copy-actions.ts line 69

I've tested the "create new collection with selected" feature and sometimes it gave me an error, then I tried the rest of the operations with selected files and almost all have some kind of issues, I even tried the "remove selected" from ce8i5's wb2 and detected problems so I think these aren't related to the file filtering feature that we're attempting to introduce on this ticket. Will have to create a bug ticket for those (if it doesn't already exist).

So with that, it LGTM. Thanks.