https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422020-04-08T16:09:25ZArvadosArvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=834562020-04-08T16:09:25ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Javier Bértoli</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=836302020-04-22T14:58:08ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-04-22</i> to <i>2020-05-06 Sprint</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=838072020-04-29T17:27:24ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/83807/diff?detail_id=80579">diff</a>)</li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=839432020-05-06T15:30:30ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-05-06 Sprint</i> to <i>2020-05-20 Sprint</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=841072020-05-14T15:49:43ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> changed from <i>Javier Bértoli</i> to <i>Ward Vandewege</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=842812020-05-20T13:24:37ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Ready for review at commit:1a330c6a87b93349fabe10789f287707e3bab7ad on branch 16319-unify-build-dependencies in the packer repo.</p> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=843072020-05-20T15:45:30ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-05-20 Sprint</i> to <i>2020-06-03 Sprint</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=843282020-05-20T18:46:56ZTom Cleggtom@curii.com
<ul></ul>In <code>jenkins/node-ready.sh</code>
<ul>
<li>should probably add "set -eo pipefail", even if it means ignoring errors explicitly in some places (perhaps "systemctl enable ... || true" ?)</li>
<li>the "nc" loop with RETVAL looks like it could be simplified to something like<br /><pre>
while ! nc -w1 -z git.arvados.org 22; do
echo "..."
sleep 1
done
echo "connected!"
</pre></li>
<li>could DRY the /tmp/boot-wait.log stuff (copy all stdout and stderr to log) by putting this delightful bit of bash at the top:<br /><pre>
exec > >(tee -a /tmp/boot-wait.log) 2>&1
</pre></li>
</ul>
In <code>jenkins/run_jenkins-slave-image-run-tests.sh</code>
<ul>
<li><code>sudo go run ./cmd/arvados-server install -type development</code> should be <code>-type test</code> (although they currently do the same thing)</li>
<li>Does "chown jenkins:jenkins arvados.git" really do anything useful, without <code>-R</code>?</li>
<li><code>arvados-server install</code> installs go binaries to <code>/usr/local/bin/</code> so having a possibly-different version in <code>/usr/bin/go</code> might get confusing one day. Maybe delete <code>"ln -s /usr/lib/go-1.14/bin/go /usr/bin/go"</code> here, and invoke it explicitly as <code>"/usr/lib/go-1.14/bin/go run ./cmd/arvados-server ..."</code> instead?</li>
</ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=843342020-05-20T20:05:28ZWard Vandewegeward@curii.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
In <code>jenkins/node-ready.sh</code>
<ul>
<li>should probably add "set -eo pipefail", even if it means ignoring errors explicitly in some places (perhaps "systemctl enable ... || true" ?)</li>
<li>the "nc" loop with RETVAL looks like it could be simplified to something like<br />[...]</li>
<li>could DRY the /tmp/boot-wait.log stuff (copy all stdout and stderr to log) by putting this delightful bit of bash at the top:<br />[...]</li>
</ul>
In <code>jenkins/run_jenkins-slave-image-run-tests.sh</code>
<ul>
<li><code>sudo go run ./cmd/arvados-server install -type development</code> should be <code>-type test</code> (although they currently do the same thing)</li>
<li>Does "chown jenkins:jenkins arvados.git" really do anything useful, without <code>-R</code>?</li>
<li><code>arvados-server install</code> installs go binaries to <code>/usr/local/bin/</code> so having a possibly-different version in <code>/usr/bin/go</code> might get confusing one day. Maybe delete <code>"ln -s /usr/lib/go-1.14/bin/go /usr/bin/go"</code> here, and invoke it explicitly as <code>"/usr/lib/go-1.14/bin/go run ./cmd/arvados-server ..."</code> instead?</li>
</ul>
</blockquote>
<p>OK, everything incorporated at commit:14b4c53c0f4ae577da2c3b7ba71b824dfc05963d</p> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=843372020-05-20T20:49:41ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> Arvados - Feature #16319: packer build for jenkins images updated to use arvados-server installhttps://dev.arvados.org/issues/16319?journal_id=876862020-10-07T02:12:02ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>25</i></li></ul>