Bug #16326

[doc] improve MaxConcurrentRequests and MaxKeepBlobBuffers descriptions

Added by Ward Vandewege 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
04/09/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

The detail on how to calculate MaxKeepBlobBuffers was accidentally dropped in the 2.0 doc update.

The description for MaxConcurrentRequests erroneously states that it is only used by Keepstore.

The description for MaxConcurrentRequests states that the default (0) means no limit, but in the Keepstore code, 0 is translated to 2 * MaxKeepBlobBuffers.


Subtasks

Task #16327: ReviewResolvedTom Clegg

Associated revisions

Revision 28d45000 (diff)
Added by Ward Vandewege 8 months ago

documentation: update descriptions for MaxKeepBlobBuffers and MaxConcurrentRequests

keepstore: MaxConcurrentRequests set to zero should mean no limit

keepstore: warn if MaxConcurrentRequests is set to a nonzero value less
than MaxConcurrentRequests.

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 10c9f66f (diff)
Added by Ward Vandewege 8 months ago

documentation: update descriptions for MaxKeepBlobBuffers and MaxConcurrentRequests

keepstore: MaxConcurrentRequests set to zero should mean no limit

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision b0205e1c (diff)
Added by Ward Vandewege 8 months ago

documentation: update descriptions for MaxKeepBlobBuffers and MaxConcurrentRequests

keepstore: MaxConcurrentRequests set to zero should mean no limit

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 66fe512e
Added by Ward Vandewege 8 months ago

Merge branch '16326-doc-and-keepstore-update'

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 9d4be0f5 (diff)
Added by Ward Vandewege 8 months ago

Fix tests.

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 845381a1 (diff)
Added by Ward Vandewege 8 months ago

documentation: update descriptions for MaxKeepBlobBuffers and MaxConcurrentRequests

keepstore: MaxConcurrentRequests set to zero should mean no limit

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision da84332f (diff)
Added by Ward Vandewege 8 months ago

Fix tests.

refs #16326

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Ward Vandewege 8 months ago

  • Status changed from New to In Progress

#2 Updated by Ward Vandewege 8 months ago

  • Description updated (diff)

#3 Updated by Ward Vandewege 8 months ago

Developer tests running at https://ci.arvados.org/view/Developer/job/developer-run-tests/1805/. Ready for review at b0205e1c5e8bff315b475c6a2122bb23fbead70c on branch 16326-doc-and-keepstore-update

#4 Updated by Tom Clegg 8 months ago

  • Release set to 25

LGTM, thanks. Should apply to master, too.

#5 Updated by Ward Vandewege 8 months ago

  • Release changed from 25 to 30
  • Status changed from In Progress to Resolved

Merged to master.

Also available in: Atom PDF