Project

General

Profile

Actions

Bug #16343

closed

[controller] bad routing of container_requests#create call when LoginCluster is in use

Added by Tom Clegg almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
04/28/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

In source:lib/controller/fed_containers.go a "create container request" call is supposed to be handled as a local request when no remote cluster ID is specified.

However, when LoginCluster is in use, local tokens have a UUID indicating the LoginCluster's ID, not the local cluster's ID, and this causes the "short circuit to local API server" condition to be missed. The request does ends up being directed to the correct (local) cluster, but it goes through the "remote" code path, which depends on the local cluster's config having a RemoteClusters entry for itself.

This should be fixed so it doesn't depend on having a "self" entry in RemoteClusters.


Subtasks 1 (0 open1 closed)

Task #16357: Review 16343-create-cr-with-logincluster-tokenResolvedPeter Amstutz04/28/2020

Actions
Actions #1

Updated by Tom Clegg almost 4 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Tom Clegg almost 4 years ago

16343-create-cr-with-logincluster-token @ e884be43ee0209ff28fdc3c105910f78edf64996 -- developer-run-tests: #1822

Actions #3

Updated by Peter Amstutz almost 4 years ago

LGTM.

Actions #4

Updated by Anonymous almost 4 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF