Bug #16382

arvados-cwl-conformance-tests failing in jenkins

Added by Peter Amstutz over 1 year ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Target version:
Start date:
06/25/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #16541: Review 16382-cwl-path-in-default ResolvedPeter Amstutz

Task #16570: integration test failingResolvedPeter Amstutz


Related issues

Related to Arvados - Bug #16482: [crunch] bump a-c-r's cwltool dependency to pass CWL v1.2.0-dev3 testsResolved06/17/2020

Associated revisions

Revision 93ef09e1
Added by Peter Amstutz over 1 year ago

Merge branch '16382-cwl-path-in-default' refs #16382

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

Revision 8921a456 (diff)
Added by Peter Amstutz over 1 year ago

Fixed default value bug, don't expect test to fail any more

refs #16382

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

Revision f344802c (diff)
Added by Peter Amstutz over 1 year ago

Restore check for 'id' field for CWL v1.0 only

On further research, I realized why the check for 'id' on embedded
process objects was in place (to catch potential id conflicts earlier
instead of later), however the underlying problem is resolved in cwl
1.1+

refs #16382

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-05-20 Sprint to 2020-06-03 Sprint

#2 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-06-03 Sprint to 2020-06-17 Sprint

#3 Updated by Peter Amstutz over 1 year ago

  • Assigned To set to Ward Vandewege
  • Status changed from New to In Progress
  • Subject changed from arvados-cwl-conformance-tests failing in jenkins to arvados-cwl-conformance-tests failing in jenkins

#4 Updated by Ward Vandewege over 1 year ago

  • Related to Bug #16482: [crunch] bump a-c-r's cwltool dependency to pass CWL v1.2.0-dev3 tests added

#5 Updated by Ward Vandewege over 1 year ago

  • Assigned To changed from Ward Vandewege to Peter Amstutz
  • Subject changed from arvados-cwl-conformance-tests failing in jenkins to arvados-cwl-conformance-tests failing in jenkins

#6 Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2020-06-17 Sprint to 2020-07-01 Sprint

#7 Updated by Peter Amstutz over 1 year ago

  • Category set to Tests

#8 Updated by Peter Amstutz over 1 year ago

v1.0 tests failing: 150, 151, 184 (probably all for the same reason).

#9 Updated by Peter Amstutz over 1 year ago

16382-cwl-path-in-default @ 4d3e80d1823594a6b1e2cb6cb34d7b098da379c6

https://ci.arvados.org/view/Developer/job/developer-run-tests/1931/

Fixed 3 resulting in failing tests:

  • When packing workflow convert "path" to "location"
  • Don't assert that embedded process objects have 'id' fields (tests pass without this check, not sure why it was added originally)
  • Handle secondaryFiles that use expressions that return lists

#11 Updated by Ward Vandewege over 1 year ago

Peter Amstutz wrote:

rebased on master

16382-cwl-path-in-default @ bda96db7a411b1a16d6111c46f9732379c8c8426

https://ci.arvados.org/view/Developer/job/developer-run-tests/1932/

LGTM thanks!

#12 Updated by Peter Amstutz over 1 year ago

  • Status changed from In Progress to Resolved

#13 Updated by Peter Amstutz about 1 year ago

  • Release set to 25

#14 Updated by Peter Amstutz 7 months ago

  • Release changed from 25 to 38

Also available in: Atom PDF