Feature #16451
closed[testing] give run-tests interactive a mode to run a test many times
Updated by Ward Vandewege over 4 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege over 4 years ago
Ready for review in 8f6f8d5d727c9b0ae4600c7b546db248e012d203 on branch 16451-run-tests-interactive-run-test-many-times
Updated by Tom Clegg over 4 years ago
Shifting the vars around this way leaves testargs as " "
instead of empty when there are no opts provided. AFAICS the only side effect is that the "go test" recipe won't use coverflags, which doesn't seem too important. Maybe worth doing something like this instead?
if [[ "${nextcmd}" =~ ^[0-9] ]]; then read count nextcmd <<<"${nextcmd}" fi
Other than that nit, LGTM.
Updated by Ward Vandewege over 4 years ago
Tom Clegg wrote:
Shifting the vars around this way leaves testargs as
" "
instead of empty when there are no opts provided. AFAICS the only side effect is that the "go test" recipe won't use coverflags, which doesn't seem too important. Maybe worth doing something like this instead?[...]
Other than that nit, LGTM.
Yes! That's also a nice simplification. Merged with that fix, thanks.
Updated by Anonymous over 4 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|9007cff9babd5140d0b7bd0ded316afb3656d286.