Feature #16451
closed
- Status changed from New to In Progress
Shifting the vars around this way leaves testargs as " "
instead of empty when there are no opts provided. AFAICS the only side effect is that the "go test" recipe won't use coverflags, which doesn't seem too important. Maybe worth doing something like this instead?
if [[ "${nextcmd}" =~ ^[0-9] ]]; then
read count nextcmd <<<"${nextcmd}"
fi
Other than that nit, LGTM.
Tom Clegg wrote:
Shifting the vars around this way leaves testargs as " "
instead of empty when there are no opts provided. AFAICS the only side effect is that the "go test" recipe won't use coverflags, which doesn't seem too important. Maybe worth doing something like this instead?
[...]
Other than that nit, LGTM.
Yes! That's also a nice simplification. Merged with that fix, thanks.
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Also available in: Atom
PDF