Install docs mention using Salt
#11 Updated by Lucas Di Pentima 13 days ago
- Added 77bf8cb84 to include the new salt documentation to the install guide. (wasn’t able to reach it from anywhere)
- When doing a
rake generate && rake runlocally to see the rendered doc site, I’m seeing several formatting issues with the new documentation.
- Also, some links land on incorrect locations.
- The “install dependencies” section feels a bit empty. Can we have an example of how to install them using salt? If it does need extra salt formulas, maybe just an example of one component is enough.
- In the
- There’s a
BRANCHenvvar set to some value. Is this valid? The comment says that it will switch to the provided branch name before running, I think it shouldn’t be set by default.
- Running the script as a regular user fails when trying to create
/srv/<something>dirs for lack of permission reasons
- There’s a
#14 Updated by Lucas Di Pentima 8 days ago
- I think the “SaltStack quick start” should be listed as an installation option on the “Overview” (Install doc section).
- On the rendered doc site, section “For the impatient”, the first sentence gets splitted in 2 after the 4th word (tested on Safari & Chrome browsers). The same happens on the “Introduction” section. Other lines also get cut on different lenghts, what I’m thinking it’s happening is that the line breaks on the documentation source file gets translated literally on the rendered site. Every sentence should be written on just 1 (sometimes long) line of text so that the browser decides when to break it depending on the window's width.
- The code boxes have an initial empty line that could be avoided for better aesthetics.
- The documentation states that the
provision.shscript should be run as
root. OTOH, there’re “sudo” executions inside it, but if run as a normal user, it will fail creating some directories inside
/srv/so I think it would be clearer to not use “sudo” and check for the current user so that it fails when it’s not root.
- There’s some issue with link rendering on the “Install dependencies” section.
- Both times I tried running the
provision.shscript as root on a fresh Debian Buster VM, the process got stuck at:
[INFO ] Executing command ['dpkg', '--get-selections', '*'] in directory '/root' [INFO ] Executing command ['systemd-run', '--scope', '--description', '"salt.loaded.int.module.aptpkg"', 'apt-get', '-q', '-y', '-o', 'DPkg::Options::=--force-confold', '-o', 'DPkg::Options::=--force-confdef', 'install', 'arvados-api-server'] in directory '/root'
(…not sure if the above was because I had not enough patience.)
- When trying
vagrant up, it took some time but finished correctly. It took around 800 seconds, not sure if this is normal but it would be nice to mention it on the documentation
- After running vagrant up, I don’t know how to contact Arvados, should vagrant provide an exported workbench URL when finishing? If there’s a default IP/port that vagrant uses, it would be useful to say so on the doc page.
#15 Updated by Javier Bértoli 6 days ago
- Made some more changes to the docs and scripts, following Lucas' suggestions. (commit 4bcdecf24@arvados, branch 16471-install-using-salt)
- Refactored some things in the Salt formula
- Made the
provision.shscript able to reload the configuration and re-rerun salt so, if you run it in a VM, can just reload it and will update all the configuration.
#19 Updated by Ward Vandewege 2 days ago
Javier Bértoli wrote:
Added a few lines regarding DNS and changing 'source-based' -> 'package-based' (commit 525583680@arvados, branch 16471-install-using-salt)
Okay I see how that was confusing. I pushed a fix for the `source-based` wording at 7544023f69773730d69a0c614f1220e7936aea5d on branch 16471-install-using-salt. With that, I think this is good to be merged from my perspective (but I have only reviewed the documentation, I have not tried the actual Salt formula!).