Bug #16472

Shows error snackbar even when the code will handle the error.

Added by Lucas Di Pentima over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/23/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

We have added in the past a service layer feature that makes any request error to show up on the UI. This is useful as a catch-all measure to see hidden issues but sometimes workbench2 makes requests that have the potential to fail and the code even handles those failures, but the UI snackbar is displayed the same, making for a confusing UX.

There's some WIP in the branch 16118-service-layer-snackbar-fix, adding an optional parameter to the service layer methods so that on those cases when the error is handled, the snackbar can be avoided, but it's not working properly yet.
This branch comes from working on #16118, because the snackbar was originally causing issues with its tests, but as that was fixed in some other way, it is now on its own ticket.


Subtasks

Task #16484: Review 16472-service-layer-snackbar-fixResolvedPeter Amstutz


Related issues

Related to Arvados - Bug #16118: Offers editing actions on read-only collectionsResolved02/28/2020

Associated revisions

Revision a69f1b21
Added by Lucas Di Pentima over 1 year ago

Merge branch '16472-service-layer-snackbar-fix'
Closes #16472

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Lucas Di Pentima over 1 year ago

  • Related to Bug #16118: Offers editing actions on read-only collections added

#2 Updated by Lucas Di Pentima over 1 year ago

  • Target version changed from 2020-06-03 Sprint to 2020-06-17 Sprint

#3 Updated by Lucas Di Pentima over 1 year ago

  • Status changed from New to In Progress

#4 Updated by Lucas Di Pentima over 1 year ago

  • Target version changed from 2020-06-17 Sprint to 2020-07-01 Sprint

#5 Updated by Lucas Di Pentima over 1 year ago

Rebased & renamed the mentioned branch on arvados-workbench2|61e9b81 - branch 16472-service-layer-snackbar-fix
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/52/

  • Adds boolean parameter to the service layer so that on those cases where the code handles possible request failures, the "error snackbar" and console message are not displayed.
  • Uses the parameter to avoid showing an error when using the "ancestors service", as it was already handling errors. This makes accessing projects on "shared with me" to not show an error snackbars stream.

#6 Updated by Peter Amstutz over 1 year ago

Lucas Di Pentima wrote:

Rebased & renamed the mentioned branch on arvados-workbench2|61e9b81 - branch 16472-service-layer-snackbar-fix
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/52/

  • Adds boolean parameter to the service layer so that on those cases where the code handles possible request failures, the "error snackbar" and console message are not displayed.
  • Uses the parameter to avoid showing an error when using the "ancestors service", as it was already handling errors. This makes accessing projects on "shared with me" to not show an error snackbars stream.

This LGTM.

#7 Updated by Anonymous over 1 year ago

  • Status changed from In Progress to Resolved

#8 Updated by Lucas Di Pentima about 1 year ago

  • Release changed from 20 to 25

Also available in: Atom PDF