Bug #16472
closed
Shows error snackbar even when the code will handle the error.
Description
We have added in the past a service layer feature that makes any request error to show up on the UI. This is useful as a catch-all measure to see hidden issues but sometimes workbench2 makes requests that have the potential to fail and the code even handles those failures, but the UI snackbar is displayed the same, making for a confusing UX.
There's some WIP in the branch 16118-service-layer-snackbar-fix, adding an optional parameter to the service layer methods so that on those cases when the error is handled, the snackbar can be avoided, but it's not working properly yet.
This branch comes from working on #16118, because the snackbar was originally causing issues with its tests, but as that was fixed in some other way, it is now on its own ticket.
Related issues
Updated by Lucas Di Pentima over 4 years ago
- Related to Bug #16118: Offers editing actions on read-only collections added
Updated by Lucas Di Pentima over 4 years ago
- Target version changed from 2020-06-03 Sprint to 2020-06-17 Sprint
Updated by Lucas Di Pentima over 4 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 4 years ago
- Target version changed from 2020-06-17 Sprint to 2020-07-01 Sprint
Updated by Lucas Di Pentima over 4 years ago
Rebased & renamed the mentioned branch on arvados-workbench2|61e9b81 - branch 16472-service-layer-snackbar-fix
Test run: developer-tests-workbench2: #52
- Adds boolean parameter to the service layer so that on those cases where the code handles possible request failures, the "error snackbar" and console message are not displayed.
- Uses the parameter to avoid showing an error when using the "ancestors service", as it was already handling errors. This makes accessing projects on "shared with me" to not show an error snackbars stream.
Updated by Peter Amstutz over 4 years ago
Lucas Di Pentima wrote:
Rebased & renamed the mentioned branch on arvados-workbench2|61e9b81 - branch
16472-service-layer-snackbar-fix
Test run: developer-tests-workbench2: #52
- Adds boolean parameter to the service layer so that on those cases where the code handles possible request failures, the "error snackbar" and console message are not displayed.
- Uses the parameter to avoid showing an error when using the "ancestors service", as it was already handling errors. This makes accessing projects on "shared with me" to not show an error snackbars stream.
This LGTM.
Updated by Anonymous over 4 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|a69f1b21123b904a33ab2fd289bc9f170bc42ff2.