Project

General

Profile

Actions

Story #16561

closed

Add "Listen" to Services config

Added by Peter Amstutz over 2 years ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/24/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

"InternalURLs" is used to provide the bind address but people expect it to mean a URL that is valid on the private network.

Add a "Listen" field which expresses the bind addresses that the server will use. Then "InternalURLs" can mean URLs that are valid on the private network.


Subtasks 1 (0 open1 closed)

Task #19189: Review 16561-listen-urlResolvedLucas Di Pentima06/24/2022

Actions

Related issues

Related to Arvados Epics - Story #16303: Kubernetes supportIn Progress06/01/202312/31/2023

Actions
Related to Arvados - Story #17667: Install docs explains InternalURL / ExternalURL, private networks & split DNSResolvedWard Vandewege12/06/2021

Actions
Related to Arvados - Feature #18563: Simplify/streamline InternalURLs/ExternalURL situationNew

Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz over 2 years ago

Actions #4

Updated by Tom Clegg about 1 year ago

  • Related to Story #17667: Install docs explains InternalURL / ExternalURL, private networks & split DNS added
Actions #5

Updated by Tom Clegg about 1 year ago

a possible approach: 16561-listen-address @ 3aac8e596 (rebased branch originally made during #17667)

Actions #6

Updated by Tom Clegg about 1 year ago

  • Related to Feature #18563: Simplify/streamline InternalURLs/ExternalURL situation added
Actions #7

Updated by Peter Amstutz 9 months ago

  • Target version set to 2022-05-25 sprint
Actions #8

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #9

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #10

Updated by Peter Amstutz 8 months ago

  • Assigned To set to Tom Clegg
Actions #11

Updated by Tom Clegg 8 months ago

Revived branch from #17667, rebased, changed ListenAddress to InternalURLs.*.ListenURL.

16561-listen-url @ 378c9c6a57cc24d74fe4ae1c694846d55fad3736 -- developer-run-tests: #3178

Actions #12

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #13

Updated by Peter Amstutz 7 months ago

  • Status changed from New to In Progress
Actions #15

Updated by Lucas Di Pentima 7 months ago

A couple of questions:

  • At lib/service/cmd.go:L244 I find this use of conditionals somewhat hard to read, is there a reason to use it like that, other than saving indentation space?
  • Do you think getListenAddr() could benefit from a set of tests covering the different cases with/without the envvar, with/without ListenURL?
Actions #16

Updated by Tom Clegg 7 months ago

Rearranged the conditionals to make it easier to read.

Added tests for getListenAddr() ... and fixed the bug it found ("http[s]://foo/" was returning an error instead of trying to listen on port 80/443).

16561-listen-url @ 11f4d90ff07de3557a86d78cb8623ad059633d04 -- developer-run-tests: #3206

retry wb1 developer-run-tests-apps-workbench-integration: #3437

Actions #18

Updated by Lucas Di Pentima 7 months ago

This LGTM, thanks!

Actions #19

Updated by Tom Clegg 7 months ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|6b77f5f193b9c7e931d2e0b0712c1b27cd547fc8.

Actions #20

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF