Story #16561
closed
Add "Listen" to Services config
100%
Description
"InternalURLs" is used to provide the bind address but people expect it to mean a URL that is valid on the private network.
Add a "Listen" field which expresses the bind addresses that the server will use. Then "InternalURLs" can mean URLs that are valid on the private network.
Related issues
Updated by Peter Amstutz over 2 years ago
- Related to Story #16303: Kubernetes support added
Updated by Tom Clegg about 1 year ago
- Related to Story #17667: Install docs explains InternalURL / ExternalURL, private networks & split DNS added
Updated by Tom Clegg about 1 year ago
- Related to Feature #18563: Simplify/streamline InternalURLs/ExternalURL situation added
Updated by Peter Amstutz 9 months ago
- Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Updated by Peter Amstutz 8 months ago
- Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Updated by Tom Clegg 8 months ago
Revived branch from #17667, rebased, changed ListenAddress to InternalURLs.*.ListenURL.
16561-listen-url @ 378c9c6a57cc24d74fe4ae1c694846d55fad3736 -- developer-run-tests: #3178
Updated by Peter Amstutz 7 months ago
- Target version changed from 2022-06-22 Sprint to 2022-07-06
Updated by Tom Clegg 7 months ago
16561-listen-url @ bc614b56c377861b1a51a83778a02320c09025ce -- developer-run-tests: #3197
Updated by Lucas Di Pentima 7 months ago
A couple of questions:
- At
lib/service/cmd.go:L244I find this use of conditionals somewhat hard to read, is there a reason to use it like that, other than saving indentation space? - Do you think
getListenAddr()could benefit from a set of tests covering the different cases with/without the envvar, with/withoutListenURL?
Updated by Tom Clegg 7 months ago
Rearranged the conditionals to make it easier to read.
Added tests for getListenAddr() ... and fixed the bug it found ("http[s]://foo/" was returning an error instead of trying to listen on port 80/443).
16561-listen-url @ 11f4d90ff07de3557a86d78cb8623ad059633d04 -- developer-run-tests: #3206
retry wb1 developer-run-tests-apps-workbench-integration: #3437
Updated by Lucas Di Pentima 7 months ago
wb1 integration tests re-retry: developer-run-tests-apps-workbench-integration: #3438