Project

General

Profile

Actions

Bug #16565

closed

Don't upload development images as arvados/jobs:latest to Docker hub

Added by Peter Amstutz about 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/19/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Currently the script to build arvados/jobs either has an explicit version (for stable builds) or it determines the arvados-cwl-runner version and tags it as both that version and "latest".

We should not push development versions as "latest".

From discussion: we shouldn't have any "latest" tag at all. Ensure the build pipeline works without assuming "latest".

Separately: workbench submits workflows using the "latest" tag, but really this should match the version of the cluster that is installed.


Subtasks 1 (0 open1 closed)

Task #16696: ReviewResolvedPeter Amstutz08/19/2020

Actions

Related issues

Related to Arvados - Story #16602: Workbench 2 uses correct version of arvados/jobs when submitting a workflow, not "latest"ResolvedPeter Amstutz08/26/2020

Actions
Actions #1

Updated by Peter Amstutz about 2 years ago

  • Description updated (diff)
  • Subject changed from Don't upload development images as arvados/jobs:latest to Docker hub, latest should be latest stable. to Don't upload development images as arvados/jobs:latest to Docker hub
Actions #2

Updated by Peter Amstutz about 2 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz almost 2 years ago

  • Assigned To set to Peter Amstutz
Actions #4

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from 2020-07-15 to 2020-08-12 Sprint
Actions #5

Updated by Peter Amstutz almost 2 years ago

  • Assigned To deleted (Peter Amstutz)
Actions #6

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
Actions #7

Updated by Ward Vandewege almost 2 years ago

  • Assigned To set to Ward Vandewege
Actions #8

Updated by Ward Vandewege almost 2 years ago

  • Status changed from New to In Progress
Actions #9

Updated by Ward Vandewege almost 2 years ago

Build system change ready for review at 85864f3fbee06c2dd0729d7c63eddde7f935746e on branch 16565-no-more-latest-docker-jobs-image

Actions #10

Updated by Peter Amstutz almost 2 years ago

  • Related to Story #16602: Workbench 2 uses correct version of arvados/jobs when submitting a workflow, not "latest" added
Actions #11

Updated by Peter Amstutz almost 2 years ago

Ward Vandewege wrote:

Build system change ready for review at 85864f3fbee06c2dd0729d7c63eddde7f935746e on branch 16565-no-more-latest-docker-jobs-image

This LGTM.

We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".

Actions #12

Updated by Ward Vandewege almost 2 years ago

Peter Amstutz wrote:

This LGTM.

Thanks, I merged it.

We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".

Perhaps the thing to do would be to tag the 2.0.4 image as 'latest' for backwards compatibility, at least for a while? What would happen in Workbench if there is no latest tag?

Actions #13

Updated by Ward Vandewege almost 2 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #14

Updated by Peter Amstutz almost 2 years ago

Ward Vandewege wrote:

Peter Amstutz wrote:

This LGTM.

Thanks, I merged it.

We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".

Perhaps the thing to do would be to tag the 2.0.4 image as 'latest' for backwards compatibility, at least for a while? What would happen in Workbench if there is no latest tag?

Workbench only cares that the Arvados instance has an image with the "latest" tag, not that Docker hub has one.

Actions #15

Updated by Peter Amstutz over 1 year ago

  • Release set to 25
Actions

Also available in: Atom PDF