Bug #16565
closed
Don't upload development images as arvados/jobs:latest to Docker hub
Description
Currently the script to build arvados/jobs either has an explicit version (for stable builds) or it determines the arvados-cwl-runner version and tags it as both that version and "latest".
We should not push development versions as "latest".
From discussion: we shouldn't have any "latest" tag at all. Ensure the build pipeline works without assuming "latest".
Separately: workbench submits workflows using the "latest" tag, but really this should match the version of the cluster that is installed.
Related issues
Updated by Peter Amstutz almost 4 years ago
- Description updated (diff)
- Subject changed from Don't upload development images as arvados/jobs:latest to Docker hub, latest should be latest stable. to Don't upload development images as arvados/jobs:latest to Docker hub
Updated by Peter Amstutz almost 4 years ago
- Target version changed from 2020-07-15 to 2020-08-12 Sprint
Updated by Peter Amstutz almost 4 years ago
- Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
Updated by Ward Vandewege over 3 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege over 3 years ago
Build system change ready for review at 85864f3fbee06c2dd0729d7c63eddde7f935746e on branch 16565-no-more-latest-docker-jobs-image
Updated by Peter Amstutz over 3 years ago
- Related to Idea #16602: Workbench 2 uses correct version of arvados/jobs when submitting a workflow, not "latest" added
Updated by Peter Amstutz over 3 years ago
Ward Vandewege wrote:
Build system change ready for review at 85864f3fbee06c2dd0729d7c63eddde7f935746e on branch 16565-no-more-latest-docker-jobs-image
This LGTM.
We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".
Updated by Ward Vandewege over 3 years ago
Peter Amstutz wrote:
This LGTM.
Thanks, I merged it.
We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".
Perhaps the thing to do would be to tag the 2.0.4 image as 'latest' for backwards compatibility, at least for a while? What would happen in Workbench if there is no latest tag?
Updated by Ward Vandewege over 3 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|e28343a194a91f708ec8da8c4dc8eb956fecb85d.
Updated by Peter Amstutz over 3 years ago
Ward Vandewege wrote:
Peter Amstutz wrote:
This LGTM.
Thanks, I merged it.
We should probably also delete the 'latest' tag image on Docker hub? Aside from #16602 I don't know what other parts of the system assume "latest".
Perhaps the thing to do would be to tag the 2.0.4 image as 'latest' for backwards compatibility, at least for a while? What would happen in Workbench if there is no latest tag?
Workbench only cares that the Arvados instance has an image with the "latest" tag, not that Docker hub has one.