Feature #16623

Can reference compute subnet in different resource group on Azure

Added by Peter Amstutz 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
07/22/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Currently the Network and Subnet for the NIC need to be in the same resource group as the NIC and VM will be created. Add a separate NetworkResourceGroup configuration option to allow referencing other Networks/Subnets when creating the virtual NIC.


Subtasks

Task #16624: Review 16623-azure-subnetResolvedPeter Amstutz

Associated revisions

Revision 8713dc0a (diff)
Added by Peter Amstutz 2 months ago

16623: Add NetworkResourceGroup option for Azure

refs #16623

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

Revision 4d3ddc87 (diff)
Added by Peter Amstutz 2 months ago

16623: Add NetworkResourceGroup to install-dispatch-cloud

refs #16623

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

Revision 00964013 (diff)
Added by Peter Amstutz about 1 month ago

16623: Add NetworkResourceGroup option for Azure

refs #16623

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 2 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 2 months ago

  • Subject changed from Can reference compute subnet in different resource group to Can reference compute subnet in different resource group on Azure

#3 Updated by Peter Amstutz 2 months ago

  • Assigned To set to Peter Amstutz

#5 Updated by Lucas Di Pentima 2 months ago

Reviewing 7cd9bca

  • The update seems super trivial and looks good, but it would be nice to test the new fallback ResourceGroup selection mechanism, is that possible?
  • I also browsed the docs and haven’t found a lot of info about setting up azure compute nodes, only what’s on https://doc.arvados.org/v2.0/install/install-dispatch-cloud.html. Would it be useful to mention this new config knob there?

#6 Updated by Peter Amstutz about 2 months ago

  • Status changed from New to Resolved

#7 Updated by Ward Vandewege about 2 months ago

  • Release set to 25

#8 Updated by Ward Vandewege about 1 month ago

  • Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
  • Status changed from Resolved to In Progress

This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.

A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.

CI tests are at https://ci.arvados.org/view/Developer/job/developer-run-tests/2008/

#9 Updated by Peter Amstutz about 1 month ago

Ward Vandewege wrote:

This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.

A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.

CI tests are at https://ci.arvados.org/view/Developer/job/developer-run-tests/2008/

The goal of the original fix was only to reference a virtual network in a different resource group, it doesn't need to create the virtual NICs there.

#10 Updated by Peter Amstutz about 1 month ago

The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.

#11 Updated by Ward Vandewege about 1 month ago

  • Status changed from In Progress to Resolved

Peter Amstutz wrote:

The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.

Yes, you are right, I just tested it. Patch unnecessary and withdrawn, sorry about the noise.

Also available in: Atom PDF