Project

General

Profile

Actions

Feature #16623

closed

Can reference compute subnet in different resource group on Azure

Added by Peter Amstutz almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Story points:
-
Release relationship:
Auto

Description

Currently the Network and Subnet for the NIC need to be in the same resource group as the NIC and VM will be created. Add a separate NetworkResourceGroup configuration option to allow referencing other Networks/Subnets when creating the virtual NIC.


Subtasks 1 (0 open1 closed)

Task #16624: Review 16623-azure-subnetResolvedPeter Amstutz07/22/2020Actions
Actions #1

Updated by Peter Amstutz almost 4 years ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz almost 4 years ago

  • Subject changed from Can reference compute subnet in different resource group to Can reference compute subnet in different resource group on Azure
Actions #3

Updated by Peter Amstutz almost 4 years ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Lucas Di Pentima almost 4 years ago

Reviewing 7cd9bca

  • The update seems super trivial and looks good, but it would be nice to test the new fallback ResourceGroup selection mechanism, is that possible?
  • I also browsed the docs and haven’t found a lot of info about setting up azure compute nodes, only what’s on https://doc.arvados.org/v2.0/install/install-dispatch-cloud.html. Would it be useful to mention this new config knob there?
Actions #6

Updated by Peter Amstutz almost 4 years ago

  • Status changed from New to Resolved
Actions #7

Updated by Ward Vandewege almost 4 years ago

  • Release set to 25
Actions #8

Updated by Ward Vandewege almost 4 years ago

  • Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
  • Status changed from Resolved to In Progress

This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.

A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.

CI tests are at developer-run-tests: #2008

Actions #9

Updated by Peter Amstutz almost 4 years ago

Ward Vandewege wrote:

This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.

A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.

CI tests are at developer-run-tests: #2008

The goal of the original fix was only to reference a virtual network in a different resource group, it doesn't need to create the virtual NICs there.

Actions #10

Updated by Peter Amstutz almost 4 years ago

The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.

Actions #11

Updated by Ward Vandewege almost 4 years ago

  • Status changed from In Progress to Resolved

Peter Amstutz wrote:

The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.

Yes, you are right, I just tested it. Patch unnecessary and withdrawn, sorry about the noise.

Actions #12

Updated by Peter Amstutz over 3 years ago

  • Release changed from 25 to 34
Actions

Also available in: Atom PDF