Feature #16659: Add a "Copy to Clipboard" Button for the token - Arvados

Actions

Copy link

Feature #16659

closed

Add a "Copy to Clipboard" Button for the token

Added by Daniel Kutyła over 3 years ago. Updated over 3 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Daniel Kutyła

Category:

Workbench2

Target version:

2020-08-26 Sprint

Story points:

Release:

Arvados 2.1.0

Release relationship:

Auto

Description

Users setting up their shell for accessing the Arvados API always need to copy their tokens from the dialog. A little simplification could be to provide a button to copy the token snippet into clipboard.

Subtasks 1 (0 open — 1 closed)

Related issues

Actions

Copy link

Updated by Daniel Kutyła over 3 years ago

Target version set to 2020-08-12 Sprint

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Related to Feature #16671: Copy-to-clipboard project uuid added

Actions

Copy link

Updated by Daniel Kutyła over 3 years ago

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/2ee1db29750704c6cd381483c44c98c6cff656e0
Test run: developer-tests-workbench2: #70

Added copy to clipboard button for the api token

Actions

Copy link

Updated by Lucas Di Pentima over 3 years ago

Reviewing arvados-workbench2|2ee1db2

Please take note that some tests on Jenkins failed.

When I tried to start it with yarn start, I got an error message:

Failed to compile.

/Users/lucas/Devel/git/arvados-workbench2/src/views-components/current-token-dialog/current-token-dialog.tsx
(56,37): Unnecessary semicolon

There're several unrelated changes on this commit, were those on purpose? Maybe there's some automatic tool making them on your IDE, just wanted point that out.

Actions

Copy link

Updated by Daniel Kutyła over 3 years ago

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/27f1790ada926f4c9f8a2bd23909cb1490528b3a
Test run: developer-tests-workbench2: #72

Removed not required semicolon

Actions

Copy link

Updated by Lucas Di Pentima over 3 years ago

Assigned To set to Daniel Kutyła
Status changed from New to In Progress

Reviewing arvados-workbench2|27f1790

The env vars text box now show some lines indented instead of all being aligned to the left.
The ticket’s description mentions easing the users’ worflow when they try to access a shell node, but the button only copies the token and not the entire set of environment variables that the users need to paste on their shell session.
The test checks for a snackbar to appear instead of the main desired effect (data on clipboard). I’ve checked and it seems that a Clipboard API is in the works and already has some browser support, maybe it can be used to write a test that checks the correct data is being copied to the clipboard: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API
If the entire text box is what is needed to be copied, the button's label could say "COPY TO CLIPBOARD" instead of "COPY API TOKEN"

Actions

Copy link