Arvados

Peter Amstutz wrote:

• Select which log stream to show, or all of them combined (as it already works now) (combined view needs to be sorted by timestamp)

I've been looking at this, and there's an issue related to the fact that logs are periodically flushed to the logs table and their "event_at" data seem to save the "flush time" (or rather, log record creation time?) so a combined log view may include incorrectly sorted lines. Workbench1 currently suffers from this issue.

For a perfect "all logs" merging, the code should split the lines and then parse them by their real timestamps... but there're other logs (node-info, container) that don't have embedded timestamps.

Lucas Di Pentima wrote:

Peter Amstutz wrote:

• Select which log stream to show, or all of them combined (as it already works now) (combined view needs to be sorted by timestamp)

I've been looking at this, and there's an issue related to the fact that logs are periodically flushed to the logs table and their "event_at" data seem to save the "flush time" (or rather, log record creation time?) so a combined log view may include incorrectly sorted lines. Workbench1 currently suffers from this issue.

For a perfect "all logs" merging, the code should split the lines and then parse them by their real timestamps... but there're other logs (node-info, container) that don't have embedded timestamps.

I think best effort is perfectly fine here.

Updates at arvados-workbench2|29df452f - branch 16672-live-container-logs - developer-tests-workbench2: #621

New features / fixes¶

• Improves the Multi Panel View task bar panel switching feature by waiting some milliseconds before switching to any panel. This avoids most accidental panel switches when quickly passing the mouse pointer over the task bar.
• Removes the "Log" menu item from the process' "More" (3-dotted) button.
• Adds MPVContent panel with the Log viewer, visible by default (for now? should we leave it hidden unless the process is in "Running" state?)
• The Log panel can be maximized, and will take up to 50% of the viewport when not.
• Adds font size control buttons (with 5 steps total available)
• Moves the log selector & "Go to collection" link to the panel's top to save vertical space. The "Go to collection" link is now a button.
• Adds word-wrapping control capabilities. By default, the log viewer's word-wrap mode is enabled.
• Adds "Copy to clipboard" feature for easy copy&pasting logs.
• Adds log "auto-follow" mode: in a running process scenario, if the user scrolls the log viewer all the way down, the viewer will auto-scroll to the bottom when new logs appear.
• Adds UUID & PDH link rending on logs.

Pending / missing / left for a future round?¶

• URL link rendering on logs (this wasn't added because its behavior should be different as internal UUID & PDH links, IMO).
• Log timestamp auto-conversion (should this be toggable?, if not: what should the "copy to clipboard" feature copy?)
• Perfect log ordering by timestamp: This is currently somewhat difficult to do because log records usually contain multiple log lines, as it's flushed periodically to the database.
• Tests: we should have some way to run a container or set up a fixture so that we can test the UI.

Stephen: Re: tests -- I'll be writing the needed commands on Cypress so that we can set up different containers / container_requests objects to be able to have proper tests. Will do that on this current branch but I think you've enough to be able to start reviewing.

Only thing I noticed is that after clicking a linked UUID (in my case `186304b01836978500373c7fadf127cc+156`), I have to quickly double press back to return to the run. Other than that it looks good to me!

Thanks! The PDH issue isn't a log viewer thing but the way wb2 works when "navigating to" a PDH that resolves to just 1 UUID: instead of showing a listing of all UUIDs that match, it just redirects to the collection panel for that single UUID.

Rebased and added Cypress tests at arvados-workbench2|d1fa1c8 - developer-tests-workbench2: #622

• Added some new custom commands to be able to create container requests for future further testing of the process UI.
• Added a couple of process log tests, including the log filter.

Updates at arvados-workbench2|563b376 - developer-tests-workbench2: #628

• Fixed layout issues that made some Cypress tests fail.

This lgtm!