Arvados

Updates at arvados-workbench2|202a49e - branch 16680-expired-token-handling
Test run: developer-tests-workbench2: #82

• Enhanced commonService's error reporting in order to get the status code on the error handler.
• Logs out user when receiving a 401 error with message "Not logged in"
• Changed the way "Not found" dialog is shown: instead of parsing the error message, it's displayed whenever a 404 error is received.

I'm not sure how to unit test this. I think I could make an e2e test by setting the token to something invalid and checking that the login form is shown.

Lucas Di Pentima wrote:

Updates at arvados-workbench2|202a49e - branch 16680-expired-token-handling
Test run: developer-tests-workbench2: #82

• Enhanced commonService's error reporting in order to get the status code on the error handler.
• Logs out user when receiving a 401 error with message "Not logged in"
• Changed the way "Not found" dialog is shown: instead of parsing the error message, it's displayed whenever a 404 error is received.

Tested manually, worked as expected. I noticed that if you try to download something, keep-web doesn't return good errors to the browser, but I made that a separate ticket #16774.

I'm not sure how to unit test this. I think I could make an e2e test by setting the token to something invalid and checking that the login form is shown.

I think that's a good idea. Otherwise LGTM.

Update at arvados-workbench2|68139213
Test run: developer-tests-workbench2: #86

• Fixes Dockerfile replacing the use of deprecated MAINTAINER with LABEL.
• Adds e2e test checking the auto-logout behaviour when using an invalid token.

Lucas Di Pentima wrote:

Update at arvados-workbench2|68139213
Test run: developer-tests-workbench2: #86

• Fixes Dockerfile replacing the use of deprecated MAINTAINER with LABEL.
• Adds e2e test checking the auto-logout behaviour when using an invalid token.

LGTM