Feature #16719

Basic support for collection versions

Added by Peter Amstutz 2 months ago. Updated 1 day ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/15/2020
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

  • Adjust display when a collection is not the latest version, must be read-only
  • Tell the user they need to make a copy if they want to edit it
  • Tell the user to go to the latest version if they want to share it
  • Link to the latest version
  • Also support for searching: #16718

Subtasks

Task #16756: Review 16719-collection-version-basic-uiIn ProgressPeter Amstutz


Related issues

Related to Arvados - Story #13494: Browse previous versions of a collectionIn Progress02/19/2020

History

#1 Updated by Peter Amstutz 2 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 2 months ago

  • Related to Story #13494: Browse previous versions of a collection added

#3 Updated by Peter Amstutz 2 months ago

  • Assigned To set to Lucas Di Pentima

#4 Updated by Lucas Di Pentima about 2 months ago

  • Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint

#5 Updated by Lucas Di Pentima about 1 month ago

  • Target version changed from 2020-09-09 Sprint to 2020-09-23 Sprint

#6 Updated by Lucas Di Pentima 29 days ago

  • Target version changed from 2020-09-23 Sprint to 2020-10-07 Sprint

#7 Updated by Peter Amstutz 16 days ago

  • Target version changed from 2020-10-07 Sprint to 2020-10-21 Sprint

#8 Updated by Peter Amstutz 16 days ago

  • Tracker changed from Bug to Feature

#9 Updated by Lucas Di Pentima 9 days ago

  • Status changed from New to In Progress

#10 Updated by Lucas Di Pentima 7 days ago

Updates at arvados-workbench2|feeed01f - branch 16719-collection-version-basic-ui
Test run: pending, since this depends on #16718 being merged.

  • Fixes the collection panel UI so that it correctly show old versions:
    • A custom collection icon.
    • A small note below the collection's name stating that it's a old version and what to do to edit or share it.
    • The panel is also put in "read-only mode" so the read-only icon is displayed and the modifying actions aren't available.
  • Adds integration tests for this feature and also old version searching. Depends on 16718-group-contents-collection-versions.

#11 Updated by Peter Amstutz 3 days ago

reviewing 16719-collection-version-basic-ui @ commit:feeed01f85f60a8989b32ca463b7191d0ad9bb75

I like the combined document+clock icon, could we use it other places, like the search results?

Move the "This is an old version..." text from the top of the panel to the bottom, and remove the "bold" styling (keep italics).

The labels need to explain what is going on a little bit better. Collection UUID / portable data hash should say something like "UUID/PDH for this version" and "Current version UUID" should say "Link to most recent version".

It's missing a "version number" field.

Created at / last modified should be on the main panel and not just the "details" panel. Also labels or tool tips or other text somewhere should clarify what "created at" and "last modified at" mean for past versions.

"Download selected" for files doesn't work but that might be fixed by #16812

It might be slightly clearer if the menu item "Copy to project" was labeled "Make a copy".

Not new in this branch but the size and positioning of the "copy to clipboard" icons for are kind of awkward, if you feel like tweaking that.

The positioning of the "More options" menu (which should probably be labeled "Actions") is just sort of floating in space, it makes it easy to overlook, would it be possible to put it top line of the panel, but on the right, near the expand/collapse arrow?

#12 Updated by Lucas Di Pentima 3 days ago

Updates at arvados-workbench2|8df7e312
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/132/

I like the combined document+clock icon, could we use it other places, like the search results?

Yes, on the #13494 branch I've expanded its use to other places.

Move the "This is an old version..." text from the top of the panel to the bottom, and remove the "bold" styling (keep italics).

Fixed. At first I thought the top would be a good place to show the message just in case the main panel is collapsed, but the icon also serves as a hint.

The labels need to explain what is going on a little bit better. Collection UUID / portable data hash should say something like "UUID/PDH for this version" and "Current version UUID" should say "Link to most recent version".
It's missing a "version number" field.

Both fixed. This makes the "details" tab at the "details panel" redundant. I'll be taking down the "details" tab in #13494 while adding the "versions" tab for browsing.

Created at / last modified should be on the main panel and not just the "details" panel. Also labels or tool tips or other text somewhere should clarify what "created at" and "last modified at" mean for past versions.

I'm not sure what to clarify, can you give me some example? I think the "created at" and "modified at" don't have any second meaning for old versions, they're part of the "snapshot" of that past version, but maybe I'm missing something.

It might be slightly clearer if the menu item "Copy to project" was labeled "Make a copy".

Fixed.

Not new in this branch but the size and positioning of the "copy to clipboard" icons for are kind of awkward, if you feel like tweaking that.

Yes, from time to time I try to see how to make this better, I haven't found which styling is the one affecting the icon.

The positioning of the "More options" menu (which should probably be labeled "Actions") is just sort of floating in space, it makes it easy to overlook, would it be possible to put it top line of the panel, but on the right, near the expand/collapse arrow?

Fixed. The menu is now to the left of the expand/collapse arrow.

#14 Updated by Lucas Di Pentima 2 days ago

Updates at arvados-workbench2|b5c36801

  • Unifies collection details into one component that's used from the main collection panel and the collapsable details panel.

#15 Updated by Lucas Di Pentima 2 days ago

Peter Amstutz wrote:

reviewing 16719-collection-version-basic-ui @ commit:feeed01f85f60a8989b32ca463b7191d0ad9bb75

[...]

"Download selected" for files doesn't work but that might be fixed by #16812

This seems to be a real bug, I'm tracking it down.

#16 Updated by Lucas Di Pentima 2 days ago

I've filed a new bug for the download file issue, it's not related to this particular branch: https://dev.arvados.org/issues/17018

#17 Updated by Lucas Di Pentima 1 day ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint

Also available in: Atom PDF