Feature #16719

Basic support for collection versions

Added by Peter Amstutz 9 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/15/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

  • Adjust display when a collection is not the latest version, must be read-only
  • Tell the user they need to make a copy if they want to edit it
  • Tell the user to go to the latest version if they want to share it
  • Link to the latest version
  • Also support for searching: #16718

Subtasks

Task #16756: Review 16719-collection-version-basic-uiResolvedLucas Di Pentima


Related issues

Related to Arvados - Story #13494: Browse previous versions of a collectionResolved02/19/2020

Associated revisions

Revision 7776b799
Added by Lucas Di Pentima 6 months ago

Merge branch '16719-collection-version-basic-ui'
Closes #16719

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 9 months ago

  • Related to Story #13494: Browse previous versions of a collection added

#3 Updated by Peter Amstutz 9 months ago

  • Assigned To set to Lucas Di Pentima

#4 Updated by Lucas Di Pentima 9 months ago

  • Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint

#5 Updated by Lucas Di Pentima 8 months ago

  • Target version changed from 2020-09-09 Sprint to 2020-09-23 Sprint

#6 Updated by Lucas Di Pentima 8 months ago

  • Target version changed from 2020-09-23 Sprint to 2020-10-07 Sprint

#7 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2020-10-07 Sprint to 2020-10-21 Sprint

#8 Updated by Peter Amstutz 7 months ago

  • Tracker changed from Bug to Feature

#9 Updated by Lucas Di Pentima 7 months ago

  • Status changed from New to In Progress

#10 Updated by Lucas Di Pentima 7 months ago

Updates at arvados-workbench2|feeed01f - branch 16719-collection-version-basic-ui
Test run: pending, since this depends on #16718 being merged.

  • Fixes the collection panel UI so that it correctly show old versions:
    • A custom collection icon.
    • A small note below the collection's name stating that it's a old version and what to do to edit or share it.
    • The panel is also put in "read-only mode" so the read-only icon is displayed and the modifying actions aren't available.
  • Adds integration tests for this feature and also old version searching. Depends on 16718-group-contents-collection-versions.

#11 Updated by Peter Amstutz 7 months ago

reviewing 16719-collection-version-basic-ui @ commit:feeed01f85f60a8989b32ca463b7191d0ad9bb75

I like the combined document+clock icon, could we use it other places, like the search results?

Move the "This is an old version..." text from the top of the panel to the bottom, and remove the "bold" styling (keep italics).

The labels need to explain what is going on a little bit better. Collection UUID / portable data hash should say something like "UUID/PDH for this version" and "Current version UUID" should say "Link to most recent version".

It's missing a "version number" field.

Created at / last modified should be on the main panel and not just the "details" panel. Also labels or tool tips or other text somewhere should clarify what "created at" and "last modified at" mean for past versions.

"Download selected" for files doesn't work but that might be fixed by #16812

It might be slightly clearer if the menu item "Copy to project" was labeled "Make a copy".

Not new in this branch but the size and positioning of the "copy to clipboard" icons for are kind of awkward, if you feel like tweaking that.

The positioning of the "More options" menu (which should probably be labeled "Actions") is just sort of floating in space, it makes it easy to overlook, would it be possible to put it top line of the panel, but on the right, near the expand/collapse arrow?

#12 Updated by Lucas Di Pentima 7 months ago

Updates at arvados-workbench2|8df7e312
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/132/

I like the combined document+clock icon, could we use it other places, like the search results?

Yes, on the #13494 branch I've expanded its use to other places.

Move the "This is an old version..." text from the top of the panel to the bottom, and remove the "bold" styling (keep italics).

Fixed. At first I thought the top would be a good place to show the message just in case the main panel is collapsed, but the icon also serves as a hint.

The labels need to explain what is going on a little bit better. Collection UUID / portable data hash should say something like "UUID/PDH for this version" and "Current version UUID" should say "Link to most recent version".
It's missing a "version number" field.

Both fixed. This makes the "details" tab at the "details panel" redundant. I'll be taking down the "details" tab in #13494 while adding the "versions" tab for browsing.

Created at / last modified should be on the main panel and not just the "details" panel. Also labels or tool tips or other text somewhere should clarify what "created at" and "last modified at" mean for past versions.

I'm not sure what to clarify, can you give me some example? I think the "created at" and "modified at" don't have any second meaning for old versions, they're part of the "snapshot" of that past version, but maybe I'm missing something.

It might be slightly clearer if the menu item "Copy to project" was labeled "Make a copy".

Fixed.

Not new in this branch but the size and positioning of the "copy to clipboard" icons for are kind of awkward, if you feel like tweaking that.

Yes, from time to time I try to see how to make this better, I haven't found which styling is the one affecting the icon.

The positioning of the "More options" menu (which should probably be labeled "Actions") is just sort of floating in space, it makes it easy to overlook, would it be possible to put it top line of the panel, but on the right, near the expand/collapse arrow?

Fixed. The menu is now to the left of the expand/collapse arrow.

#14 Updated by Lucas Di Pentima 7 months ago

Updates at arvados-workbench2|b5c36801

  • Unifies collection details into one component that's used from the main collection panel and the collapsable details panel.

#15 Updated by Lucas Di Pentima 7 months ago

Peter Amstutz wrote:

reviewing 16719-collection-version-basic-ui @ commit:feeed01f85f60a8989b32ca463b7191d0ad9bb75

[...]

"Download selected" for files doesn't work but that might be fixed by #16812

This seems to be a real bug, I'm tracking it down.

#16 Updated by Lucas Di Pentima 7 months ago

I've filed a new bug for the download file issue, it's not related to this particular branch: https://dev.arvados.org/issues/17018

#17 Updated by Lucas Di Pentima 7 months ago

  • Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint

#18 Updated by Lucas Di Pentima 6 months ago

  • Target version changed from 2020-11-04 Sprint to 2020-11-18

#19 Updated by Peter Amstutz 6 months ago

I did some work on the layout of collection properties and pushed them. I think we can merge this. Hopefully I didn't create any serious conflicts for your other branches.

16719-collection-version-basic-ui @ arvados-workbench2|bcb55ad2005ab4dc8c97624c1f56d410c36d15c2

https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/152/

#20 Updated by Lucas Di Pentima 6 months ago

The collection info panel layout looks A LOT better, thanks!

I had a couple of local commits that didn't pushed (master merge & silly fixes) so I merged your changes into my branch at arvados-workbench2|8095c4a7
Running tests one more time before merging: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/153/

#21 Updated by Lucas Di Pentima 6 months ago

Re-running tests at: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/154/

Previous run failed probably because of:

11:44:04 INFO[2020-11-05T14:44:04.848946023Z] postgresql cluster 11-main is down; trying to start 
11:44:05 2020-11-05 14:44:05.111 UTC [790] LOG:  listening on IPv4 address "127.0.0.1", port 5432
11:44:05 2020-11-05 14:44:05.111 UTC [790] LOG:  could not bind IPv6 address "::1": Cannot assign requested address
11:44:05 2020-11-05 14:44:05.111 UTC [790] HINT:  Is another postmaster already running on port 5432? If not, wait a few seconds and retry.
11:44:05 2020-11-05 14:44:05.116 UTC [790] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432" 
11:44:05 2020-11-05 14:44:05.136 UTC [793] LOG:  database system was shut down at 2020-09-28 16:47:32 UTC
11:44:05 2020-11-05 14:44:05.174 UTC [790] LOG:  database system is ready to accept connections
11:44:06 2020-11-05 14:44:06.005 UTC [801] root@root FATAL:  role "root" does not exist
11:44:06 INFO[2020-11-05T14:44:06.631994173Z] postgresql supports collation en_US          
11:44:06 INFO[2020-11-05T14:44:06.722075008Z] postgresql supports collation en_US.UTF-8    
11:44:06 INFO[2020-11-05T14:44:06.962037228Z] arvados role exists; superuser privileges added, password updated 
11:44:06 INFO[2020-11-05T14:44:06.962107187Z] sent SIGTERM; waiting for postgres to shut down 
11:44:06 2020-11-05 14:44:06.962 UTC [790] LOG:  received smart shutdown request
11:44:06 2020-11-05 14:44:06.969 UTC [790] LOG:  background worker "logical replication launcher" (PID 799) exited with exit code 1
11:44:06 2020-11-05 14:44:06.969 UTC [794] LOG:  shutting down
11:44:07 2020-11-05 14:44:07.047 UTC [790] LOG:  database system is shut down

#23 Updated by Anonymous 6 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#24 Updated by Peter Amstutz 6 months ago

  • Release set to 36

Also available in: Atom PDF