Bug #16720

arv-mount exception handler bug

Added by Peter Amstutz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
FUSE
Target version:
Start date:
08/28/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Seen this a few times:

2020-08-17T18:00:02.957407737Z   File "/usr/bin/arv-mount", line 10, in <module>
2020-08-17T18:00:02.957407737Z     arvados_fuse.command.Mount(args).run()
2020-08-17T18:00:02.957407737Z   File "/usr/share/python2.7/dist/python-arvados-fuse/lib/python2.7/site-packages/arvados_fuse/command.py", line 171, in run
2020-08-17T18:00:02.957491091Z     recursive=self.args.unmount_all)
2020-08-17T18:00:02.957491091Z   File "/usr/share/python2.7/dist/python-arvados-fuse/lib/python2.7/site-packages/arvados_fuse/unmount.py", line 161, in unmount
2020-08-17T18:00:02.957491091Z     sys.stderr.write(fusermount_output)
2020-08-17T18:00:02.957491091Z NameError: global name 'sys' is not defined

Subtasks

Task #16753: Review 16720-arv-mount-exceptionResolvedTom Clegg

Associated revisions

Revision ffe94bef
Added by Tom Clegg about 1 year ago

Merge branch '16720-arv-mount-exception'

fixes #16720

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz about 1 year ago

  • Description updated (diff)

#2 Updated by Tom Clegg about 1 year ago

  • Assigned To set to Tom Clegg

#3 Updated by Tom Clegg about 1 year ago

  • Status changed from New to In Progress

#4 Updated by Lucas Di Pentima about 1 year ago

I think there's some code path that isn't properly exercised on our test suite, and that's the reason we didn't catch it earlier. Is it worth checking?
If not, this LGTM as it is.

#5 Updated by Tom Clegg about 1 year ago

Yeah, this does indicate a testing gap. But this code path is hit only when we do "fusermount -u -z", check /proc/self/mountinfo, call realpath(), check /proc/self/mountinfo again, and the mount is still listed. Making this happen in a test seems too painful right now...

#6 Updated by Anonymous about 1 year ago

  • Status changed from In Progress to Resolved

#7 Updated by Peter Amstutz about 1 year ago

  • Release set to 25

Also available in: Atom PDF