Bug #16743: Some links do not work for wb2 v2.0.4 - Arvados

Actions

Copy link

Bug #16743

closed

Some links do not work for wb2 v2.0.4

Added by Daniel Kutyła over 3 years ago. Updated over 3 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Daniel Kutyła

Category:

Workbench2

Target version:

2020-09-09 Sprint

Story points:

Release:

Arvados 2.1.0

Release relationship:

Auto

Description

I'm having trouble with opening project links for arind since v2.0.4 was released, switching from wb to wb2 by changing the URL also gives a blank page, as well as opening a study after using the search, opening projects from the tree on the left works fine, though.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint

Actions

Copy link

Updated by Daniel Kutyła over 3 years ago

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/b71d59f7e1876c9eb20c2aa7c749c0acc8568b6f
Test run: developer-tests-workbench2: #79

Fixed case when parent project is undefined

Actions

Copy link

Updated by Lucas Di Pentima over 3 years ago

At file src/views-components/side-panel-button/side-panel-button.tsx line 62 there’s a debugging console.log(1) that can be removed.
I think the underlying problem is that I made a mistake by calling isProjectTrashed() with parentProj! on line 63, overriding the protection of TS’s typing system, so maybe the more elegant solution would be to just not do a recursive call without checking if parentProj is undefined, what do you think? If you don’t agree, I think it’s already OK but just wanted to avoid adding a fix over a type override error.