Bug #16743

Some links do not work for wb2 v2.0.4

Added by Daniel Kutyła about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
08/26/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

I'm having trouble with opening project links for arind since v2.0.4 was released, switching from wb to wb2 by changing the URL also gives a blank page, as well as opening a study after using the search, opening projects from the tree on the left works fine, though.


Subtasks

Task #16760: Review 16743-blank-page-for-some-linksResolvedDaniel Kutyła

Associated revisions

Revision d7b47b18
Added by Daniel Kutyła about 1 year ago

Merge branch '16743-blank-page-for-some-links'
Closes #16743

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <>

History

#1 Updated by Peter Amstutz about 1 year ago

  • Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint

#3 Updated by Lucas Di Pentima about 1 year ago

  • At file src/views-components/side-panel-button/side-panel-button.tsx line 62 there’s a debugging console.log(1) that can be removed.
  • I think the underlying problem is that I made a mistake by calling isProjectTrashed() with parentProj! on line 63, overriding the protection of TS’s typing system, so maybe the more elegant solution would be to just not do a recursive call without checking if parentProj is undefined, what do you think? If you don’t agree, I think it’s already OK but just wanted to avoid adding a fix over a type override error.

#5 Updated by Lucas Di Pentima about 1 year ago

LGTM, please merge.

#6 Updated by Daniel Kutyła about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#7 Updated by Peter Amstutz about 1 year ago

  • Release set to 25

Also available in: Atom PDF