Bug #16743
closed
Some links do not work for wb2 v2.0.4
Added by Daniel Kutyła about 4 years ago.
Updated almost 4 years ago.
Release relationship:
Auto
Description
I'm having trouble with opening project links for arind since v2.0.4 was released, switching from wb to wb2 by changing the URL also gives a blank page, as well as opening a study after using the search, opening projects from the tree on the left works fine, though.
- Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint
- At file
src/views-components/side-panel-button/side-panel-button.tsx
line 62 there’s a debugging console.log(1)
that can be removed.
- I think the underlying problem is that I made a mistake by calling
isProjectTrashed()
with parentProj!
on line 63, overriding the protection of TS’s typing system, so maybe the more elegant solution would be to just not do a recursive call without checking if parentProj
is undefined
, what do you think? If you don’t agree, I think it’s already OK but just wanted to avoid adding a fix over a type override error.
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Also available in: Atom
PDF