Arvados

Updates at 06b0aba - branch 16750-logincluster-wb1-trash-fix
Test run: developer-run-tests: #2127

• Applies .fetch_multiple_pages(false) to User request when listing trashed items and LoginCluster is set.
• Haven't been able to properly test this, and don't want to burn more time on a wb1 fix. Ideas always welcome :)

Lucas Di Pentima wrote:

Updates at 06b0aba - branch 16750-logincluster-wb1-trash-fix
Test run: developer-run-tests: #2127

• Applies .fetch_multiple_pages(false) to User request when listing trashed items and LoginCluster is set.
• Haven't been able to properly test this, and don't want to burn more time on a wb1 fix. Ideas always welcome :)

It's a small fix but it seems a little overcomplicated, I think all you need to do was add .fetch_multiple_pages(false) to the users query. If you think about it, we fetched one page of collection items, so we can't have more owner_uuids than fit on a single page anyway.

Update at 50697add7
Test run: developer-run-tests: #2129

As suggested, I've update the code so that it always queries User and Group classes with .fetch_multiple_pages(false).

Lucas Di Pentima wrote:

Update at 50697add7
Test run: developer-run-tests: #2129

As suggested, I've update the code so that it always queries User and Group classes with .fetch_multiple_pages(false).

Now there's a "federated_reqs = [User]" line that doesn't serve any purpose. And it might be good to just rebase/squash this because the history is noisy. But I'm sorry for spending so much time on such a small fix so you should feel free to merge it :-)

Updates at 45cabb9 (rebased)

Will merge. Thanks!