Project

General

Profile

Actions

Bug #16813

closed

User batch updates should avoid useless work

Added by Peter Amstutz over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Story points:
-
Release relationship:
Auto

Description

Don't update user records (or recompute permissions) if nothing has changed.

Reported that each user record being updated would trigger a full materialized permission view update. Arvados 2.1 incremental permission updates should be an improvement, but we still want to avoid triggering a redundant refresh of each individual user's permissions.


Subtasks 1 (0 open1 closed)

Task #16820: Review 16813-avoid-noop-user-updatesResolvedPeter Amstutz09/11/2020Actions
Actions #1

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Tom Clegg
Actions #3

Updated by Peter Amstutz over 3 years ago

  • Release set to 25
Actions #4

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #5

Updated by Peter Amstutz over 3 years ago

  • Category set to API
Actions #7

Updated by Peter Amstutz over 3 years ago

Tom Clegg wrote:

16813-avoid-noop-user-updates @ 98bd6c43fca91b76d528c8ed5b83c655c86ffe3c -- developer-run-tests: #2088

The initial load of the user list could be done in a single query instead of loading each user record individually. But that's not a bottleneck we set out to fix in this branch, so just something to consider for future optimization.

LGTM.

Actions #8

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions #9

Updated by Anonymous over 3 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF