Bug #16827

R SDK not returning all files from WebDAV listing

Added by Peter Amstutz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/23/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #16865: Review 16827-fix-R-sdkResolvedPeter Amstutz

Associated revisions

Revision 5c64431a
Added by Peter Amstutz about 1 year ago

Merge branch '16827-fix-R-sdk' refs #16827

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz about 1 year ago

  • Target version changed from 2020-10-07 Sprint to 2020-09-23 Sprint

#2 Updated by Peter Amstutz about 1 year ago

  • Assigned To set to Peter Amstutz

#3 Updated by Peter Amstutz about 1 year ago

  • Status changed from New to In Progress

#4 Updated by Peter Amstutz about 1 year ago

  • Target version deleted (2020-09-23 Sprint)
  • Category deleted (SDKs)

Before I can even fix this, I need to tweak it to use the "download" keep-web endpoint, not "collections".

#5 Updated by Peter Amstutz about 1 year ago

  • Target version set to 2020-10-07 Sprint

#6 Updated by Peter Amstutz about 1 year ago

16827-fix-R-sdk @ ca07e0d0c46fbe0f4e5b5a1c702a208391c0d1ad

  • Fix the file listing bug, don't blindly remove the first element from the list (that was redundant anyway, it was already supposed to remove empty elements)
  • Fix another serious bug appending a spurious '/' to the end of requests with query parameters (seems like controller is fussy about this in a way that the Rails API server isn't)
  • Regenerate ArvadosR from Arvados 2.0 discovery doc, filter out obsolete APIs
  • Fix tests.

https://ci.arvados.org/view/Developer/job/developer-run-tests/2115/

#7 Updated by Lucas Di Pentima about 1 year ago

There’re many failing tests: https://ci.arvados.org/job/developer-run-tests-services-api/2210/console — Maybe because of d371cc9 ?

I'll switch to a different review in the meantime.

#8 Updated by Peter Amstutz about 1 year ago

This seems to be some kind of initialization error.

18:04:05 ActiveRecord::NoDatabaseError: FATAL:  database "arvados_test" does not exist

Those "didn't match" errors happen when the database has not been properly (re)initialized.

#11 Updated by Lucas Di Pentima about 1 year ago

LGTM, thanks.

#12 Updated by Peter Amstutz about 1 year ago

  • Status changed from In Progress to Resolved

#13 Updated by Peter Amstutz about 1 year ago

  • Release set to 25

Also available in: Atom PDF