Project

General

Profile

Actions

Bug #16827

closed

R SDK not returning all files from WebDAV listing

Added by Peter Amstutz over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #16865: Review 16827-fix-R-sdkResolvedPeter Amstutz09/23/2020Actions
Actions #1

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2020-10-07 Sprint to 2020-09-23 Sprint
Actions #2

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Peter Amstutz
Actions #3

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Peter Amstutz over 3 years ago

  • Target version deleted (2020-09-23 Sprint)
  • Category deleted (SDKs)

Before I can even fix this, I need to tweak it to use the "download" keep-web endpoint, not "collections".

Actions #5

Updated by Peter Amstutz over 3 years ago

  • Target version set to 2020-10-07 Sprint
Actions #6

Updated by Peter Amstutz over 3 years ago

16827-fix-R-sdk @ ca07e0d0c46fbe0f4e5b5a1c702a208391c0d1ad

  • Fix the file listing bug, don't blindly remove the first element from the list (that was redundant anyway, it was already supposed to remove empty elements)
  • Fix another serious bug appending a spurious '/' to the end of requests with query parameters (seems like controller is fussy about this in a way that the Rails API server isn't)
  • Regenerate ArvadosR from Arvados 2.0 discovery doc, filter out obsolete APIs
  • Fix tests.

developer-run-tests: #2115

Actions #7

Updated by Lucas Di Pentima over 3 years ago

There’re many failing tests: developer-run-tests-services-api: #2210 /console — Maybe because of d371cc9 ?

I'll switch to a different review in the meantime.

Actions #8

Updated by Peter Amstutz over 3 years ago

This seems to be some kind of initialization error.

18:04:05 ActiveRecord::NoDatabaseError: FATAL:  database "arvados_test" does not exist

Those "didn't match" errors happen when the database has not been properly (re)initialized.

Actions #11

Updated by Lucas Di Pentima over 3 years ago

LGTM, thanks.

Actions #12

Updated by Peter Amstutz over 3 years ago

  • Status changed from In Progress to Resolved
Actions #13

Updated by Peter Amstutz over 3 years ago

  • Release set to 25
Actions

Also available in: Atom PDF