Support #16889
closed
- Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint
- Assigned To set to Ward Vandewege
- Status changed from New to In Progress
- Subject changed from Migrate 9tee4 to Salt & add formulas for slurm support to Migrate 9tee4 to Salt
16889-salt-9tee4 is ready for a review at commit:0261a938a54ed942eda2aa19337adaaf4c7cb7da
This adds the basics for 9tee4, including enough for salt control on keepproxy.9tee4. There are also a few fixes to the apt/nginx roles, which are in separate commits.
All 9tee4's arvados nodes have now been converted to Salt. The 16889-salt-9tee4 branch is ready for review at commit:d622dd5c17c3950124e07520b679a5d19934eca4
Ward, it LGTM. Only:
- A cosmetic issue: there's a line of whitespaces in pillarstack/curii/9tee4/node/shell.9tee4.curii.yaml, above
### CRONS
- There are a few entries in pillarstack/curii/9tee4/role/arvados_host.yaml
9tee4.arvadosapi.com
that can be replaced with
{{ stack['domain'] }}
Other than that, I think it's OK to merge.
Javier Bértoli wrote:
Ward, it LGTM. Only:
- A cosmetic issue: there's a line of whitespaces in pillarstack/curii/9tee4/node/shell.9tee4.curii.yaml, above
[...]
- There are a few entries in pillarstack/curii/9tee4/role/arvados_host.yaml
[...]
that can be replaced with
[...]
Other than that, I think it's OK to merge.
Thanks, fixed in commit:d19f9936fd1e8823f0b495d92ffcbe1cf16afe8f and merged.
- Status changed from In Progress to Resolved
Also available in: Atom
PDF