Project

General

Profile

Actions

Bug #16941

closed

Multi-site search showing inactive users as "logged in" but can't be searched

Added by Peter Amstutz almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/02/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #16942: Review 16941-inactive-remotesResolvedPeter Amstutz10/02/2020

Actions
Actions #1

Updated by Peter Amstutz almost 2 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Peter Amstutz almost 2 years ago

16941-inactive-remotes @ arvados-workbench2|d924f14c5a81265fbd0f550ccf498fe791fc5b54

  • Fix tests. Had to add in the ability to mock fetching the cluster config. This might be useful in other places.

developer-tests-workbench2: #118

Actions #4

Updated by Lucas Di Pentima almost 2 years ago

Integration tests failed because of some missing import problem, but I think there's also some other problem on src/store/auth/auth-action-session.ts.
It's very odd that the compiler haven't noticed this, have we disabled some type checking feature recently without noticing?

Actions #5

Updated by Peter Amstutz almost 2 years ago

Lucas Di Pentima wrote:

Integration tests failed because of some missing import problem, but I think there's also some other problem on src/store/auth/auth-action-session.ts.
It's very odd that the compiler haven't noticed this, have we disabled some type checking feature recently without noticing?

Yes, that's weird. I was running the unit tests but not the integration tests. Iit is still strange that it wasn't giving typescript compile failures. Fixed.

16941-inactive-remotes @ commit:fb3f4deaceade35ad36718ce814d6ff4d0cb996b

developer-tests-workbench2: #119

Note: as noted in standup, in my local test I was getting an unrelated test failure that seems to be due to a project table list refreshing (and changing sort order) while the context menu was open, resulting in a different item being selected. I don't know if it will happen again on Jenkins.

=> https://dev.arvados.org/issues/16951

Actions #6

Updated by Lucas Di Pentima almost 2 years ago

Just one observation:

  • At src/views/search-results-panel/search-results-panel-view.tsx line 117 there‚Äôs a debugging console.log() statement.

Other than that, it LGTM.

Actions #7

Updated by Peter Amstutz almost 2 years ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz over 1 year ago

  • Release set to 25
Actions

Also available in: Atom PDF