Bug #16956
closed
[doc] liquid code from file is not being included
Description
See for example
- https://doc.arvados.org/master/sdk/go/example.html in the 'Example program' paragraph: 'Liquid error: internal'
- https://doc.arvados.org/master/user/tutorials/git-arvados-guide.html in the 'Adding scripts to an Arvados repository' paragraph: 'Liquid error: internal'
Updated by Ward Vandewege about 4 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege about 4 years ago
- Blocks Idea #16662: Release Arvados 2.1 added
Updated by Ward Vandewege about 4 years ago
Ready for review in 33f712764465c29c20acd025ad8421726df6423f on branch 16956-doc-fix-zenweb-liquid-4
Updated by Peter Amstutz about 4 years ago
Since we're on the subject, the {% comment %} block at the top gets rendered as #<Liquid::Comment:0x0000563905a15560>
We should either fix that, remove them (and exclude it from checking), or the SPDX-License-Identifier should just be part of the file as a normal Go/Python/YAML/whatever comment.
Updated by Peter Amstutz about 4 years ago
Also I noticed you touched install/install-compute-ping.html.textile.liquid but actually both that page file and the script it embeds to can be deleted entirely.
Updated by Peter Amstutz about 4 years ago
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Updated by Ward Vandewege about 4 years ago
Peter Amstutz wrote:
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4
Updated by Peter Amstutz about 4 years ago
Ward Vandewege wrote:
Peter Amstutz wrote:
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4
LGTM
Updated by Ward Vandewege about 4 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|0924b8c3a5d500a480018c045264202ea6cb630b.