Bug #16956

[doc] liquid code from file is not being included

Added by Ward Vandewege about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Story points:
-
Release relationship:
Auto

Description

See for example


Related issues

Blocks Arvados - Story #16662: Release Arvados 2.1Resolved09/28/2020

Associated revisions

Revision 0924b8c3
Added by Ward Vandewege about 1 year ago

Merge branch '16956-doc-fix-zenweb-liquid-4' into master

closes #16956

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Ward Vandewege about 1 year ago

  • Status changed from New to In Progress

#2 Updated by Ward Vandewege about 1 year ago

  • Description updated (diff)

#3 Updated by Ward Vandewege about 1 year ago

#4 Updated by Ward Vandewege about 1 year ago

Ready for review in 33f712764465c29c20acd025ad8421726df6423f on branch 16956-doc-fix-zenweb-liquid-4

#5 Updated by Peter Amstutz about 1 year ago

Since we're on the subject, the {% comment %} block at the top gets rendered as #<Liquid::Comment:0x0000563905a15560>

We should either fix that, remove them (and exclude it from checking), or the SPDX-License-Identifier should just be part of the file as a normal Go/Python/YAML/whatever comment.

#6 Updated by Peter Amstutz about 1 year ago

Also I noticed you touched install/install-compute-ping.html.textile.liquid but actually both that page file and the script it embeds to can be deleted entirely.

#7 Updated by Peter Amstutz about 1 year ago

Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"

#8 Updated by Ward Vandewege about 1 year ago

Peter Amstutz wrote:

Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"

Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4

#9 Updated by Peter Amstutz about 1 year ago

Ward Vandewege wrote:

Peter Amstutz wrote:

Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"

Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4

LGTM

#10 Updated by Ward Vandewege about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#11 Updated by Peter Amstutz about 1 year ago

  • Release set to 25

#12 Updated by Peter Amstutz about 1 year ago

  • Release changed from 25 to 36

#13 Updated by Peter Amstutz about 1 year ago

  • Release changed from 36 to 25

Also available in: Atom PDF