Bug #16971: Issues with Project and Collection name/description not being saved/shown in the edit menu. - Arvados Workbench 2 - Arvados

File src/views/favorite-panel/favorite-panel.tsx - Lines 155-161: Commented out code
File src/views-components/context-menu/action-sets/project-action-set.ts - Line 76: Debugging console.log() call
The "Edit" Context menu doesn't work for projects on breadcrumbs and at the left-hand side tree panel.
The same issue happens in the "Public Favorites" section. This may be a sign of unnecessary duplicated code, please check if that could be eliminated.
The same issue also happens on "Shared with me" both at the left-hand side tree panel and the main panel.
The added test could also mention collection editing on its name
Also, the test is only checking for project/collection names but not descriptions.

Actions

#14

Added more extensible tests
I was unable to reproduce the issue with context menu any special steps required?

Actions

#15

The 'can edit project in favorites' test...
- ...is being called with it.only() (missed this at the previous review)
- ...is also testing collection editing, so it should reflect that on its name.
Regarding the problems mentioned in the previous review, let me explain them better:
- Breadcrumbs: While being inside a project, you can right-click on the project name on the "Projects > ProjName" breadcrumbs at the top of the project's panel. The "Edit Project" option has the same issue reported on this ticket.
- Public Favorites: When you click on the "Public Favorites" section at the left-hand side tree and then right-click on a project or collection inside the public favorites listing, you have the same issue.
- Shared with me: The same as the previous bullet point, but for the "Shared with me" section on the left-hand side tree.
The "Public Favorites" and "Shared with me" issues seem to make visible a code duplication issue that would be really good to eliminate instead of just duplicate the fix on them (if possible).

Actions

#16

Also forgot to mention that if you right-click on a project at the left-hand side tree, and click on "Edit Project", it also has issues.

Actions

#17

Fixed issues in other places

Actions

#18

The "Shared with me" case still is pending fixing.
Please write tests for all the failure cases.
In collection.spec.js there's a test called with it.only() (coming from a previous branch), please fix that too.

Actions

#19

More tests added

Actions

#20

A couple of small comments:

I think it would be nice to rename the editProjectOrCollection command to something more explicit like testEditProjectOrCollection as the command does a double-check to ensure the changes were applied, what do you think?
Some tests failed because of the lack of "guards" on the tests when removing objects of the UI. For example, on favorites.spec.js you do a couple of "Remove from favorites" actions, I think you need to wait for those favorites to disappear before doing anything else because if you immediately right-click on another object, the DOM can change from the previous action in between and make your test fail.

Actions

#21