Arvados

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/36d0bf2c656c5ff79c94216a8bfbed015bc84f7e
Test run: developer-tests-workbench2: #203

Fixed duplicated file names, added sorting in order to avoid of folder being removed before the files within them

Code mentioned above should also fix #15771 as this bug is closely related

Reviewing arvados-workbench2|36d0bf2 - branch 17016-delete-single-file-deletes-whole-collection

• The remove feature seems to work correctly now, thanks! Would you add an integration test with a case similar to what this ticket describes? (remove file in subdir) You could make one of those by creating a collection with a synthetic manifest_text like other cypress test already do, so that you don't need to upload real files.
• From reading the code and doing some testing on my own, the received paths are sorted by length descending, I suppose this is to avoid getting errors when trying to remove files that were inside subdirectories already removed. This looks ok at first but when selecting several parts of a very deep and/or populated file tree, this would make the wb2 issue too many webdav requests by individually removing many files that could be just removed in one sweep because the parent directory is already scheduled for removal. Could we make the opposite? Like, starting removing the shorter paths and once they’re gone, avoid sending delete requests to dirs/files inside the already removed ones?

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/a293a23fa93855c9c6e180bfd77880b794c24673
Test run: developer-tests-workbench2: #222

Added browser tests

Danny: Not sure if this is ready for review, but I took a look at it anyways.

• The integration tests look good. One suggestion, though: You can modify the manifest_text on the second test to directly create a collection with files inside a subdirectory by replacing . with ./subdir on the file entries, that way you could simplify a lot the test because you won't have to make it move the file. You can read more about the manifest text format here: https://doc.arvados.org/v2.1/architecture/manifest-format.html
• My second bulletpoint at note-12 is still pending to be addressed.

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d5db24f8cfa26d546596b99e644e37c72b6b1fae
Test run: developer-tests-workbench2: #226

Code optimisation

This works great, thanks!

As one last request: Could you write a unit test that test this last optimization? I think it would be really useful to have automated warranties that this keeps working as expected in the future.

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d50bc0acaab286ec7c639c2bb52280a2e3099a67
Test run: developer-tests-workbench2: #227

More unit tests

This LGTM, please merge. Thanks!