Bug #17072: local variable 'result' referenced before assignment - Arvados

Actions

Copy link

Bug #17072

closed

local variable 'result' referenced before assignment

Added by Peter Amstutz over 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Peter Amstutz

Category:

CWL

Target version:

2020-12-02 Sprint

Story points:

Release:

Arvados 2.2.0

Release relationship:

Auto

Description

Reported that a workflow that previously worked is failing with this error:

2020-11-03T13:11:13.153103185Z  [1;30mERROR [0m  [31m[container parentalGenomeAssembly_4] unable to collect output from fbe5a25467a21bb4ce5f8282cab7a047+12407:
2020-11-03T13:11:13.153103185Z ("Error collecting output for parameter 'assemblies':\n../../lib/cwl/workflow.json:1:56701: local variable 'result' referenced before assignment", {}) [0m

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Description updated (diff)

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Target version changed from 2020-11-04 Sprint to 2020-11-18

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Target version changed from 2020-11-18 to 2020-12-02 Sprint

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

This will be fixed in upstream cwltool, I'll have to update when the fix is merged and released.

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

17072-update-cwltool @ 1cfcb49baf325386a409a1fe549dfb61e4982496

Update cwltool which fixes the original error (unbound variable 'result')

Also adjusts the default submit thread concurrency to 4.

developer-run-tests: #2198

Actions

Copy link

Updated by Lucas Di Pentima over 3 years ago

I have a couple questions:

Do you think we could spare testing cwltool’s TaskQueue class, assuming it’s being tested there?
Changing nr of default threads from 1 to 4 may change the runner's RAM requirements, that seems to be 1 GB by default. Do you think this should also be adjusted?

The rest LGTM.

Actions

Copy link

Updated by Peter Amstutz over 3 years ago

Lucas Di Pentima wrote:

I have a couple questions:

Do you think we could spare testing cwltool’s TaskQueue class, assuming it’s being tested there?

I forgot move the test over when I moved TaskQueue over. Will leave it for now but I'll move it over the cwltool in the future.

Changing nr of default threads from 1 to 4 may change the runner's RAM requirements, that seems to be 1 GB by default. Do you think this should also be adjusted?

I don't think so. What the threads are doing is pretty lightweight, and the keep client object and collection cache (which are the biggest memory consumers) are shared among them.