Bug #17098

Collection "restore from previous version" button

Added by Peter Amstutz 22 days ago. Updated about 6 hours ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
11/25/2020
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #17140: Review 17098-old-version-as-headIn ProgressLucas Di Pentima


Related issues

Related to Arvados - Story #13494: Browse previous versions of a collectionResolved02/19/2020

History

#1 Updated by Peter Amstutz 22 days ago

  • Status changed from New to In Progress

#2 Updated by Lucas Di Pentima 19 days ago

  • Related to Story #13494: Browse previous versions of a collection added

#3 Updated by Lucas Di Pentima 19 days ago

  • Target version set to 2020-11-18
  • Assigned To set to Lucas Di Pentima

#4 Updated by Lucas Di Pentima 13 days ago

  • Target version changed from 2020-11-18 to 2020-12-02 Sprint

#5 Updated by Lucas Di Pentima 6 days ago

As commented on https://dev.arvados.org/issues/13494#note-59, We'll be avoiding offering the "add to favorites" action on past versions as it isn't supported by the API server.

#6 Updated by Lucas Di Pentima 6 days ago

Updates at arvados-workbench2|673bf2ac - branch 17098-old-version-as-head
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/193/

  • Refactored a function that is used to decide which kind of context menu to show. Its was being called differently from several places, sometimes returning inconsistent values.
  • Added 'Recover version' action for old collection versions.
  • Avoid offering the 'Add to favorites' action on old collection versions.
  • Updated tests.

#7 Updated by Lucas Di Pentima 5 days ago

Updates at arvados-workbench2|adc0008e
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/196/

  • Merged latest master
  • Adjusted latest's master code on the refactored function.

#8 Updated by Peter Amstutz about 11 hours ago

How hard would it be to add a confirmation dialog? Someone might select the action not knowing what it does. The confirmation dialog could also explain that this command makes it the new "head" version, but if they want a copy to work on without modifying "head", they should use "make a copy".

#9 Updated by Peter Amstutz about 10 hours ago

Also, I don't want to get sidetracked on this, but the menu item ordering is odd.

I know that Danny changed it so the menu items are sorted alphabetically. This isn't optimal but at least it is consistent. However, the actions on the "current" version "Advanced"..."Share" sorted and then starts over with "Add to favorites"..."View details".

The whole thing should be sorted together.

Although, a better way to do this would be to create a master ordered list of actions (with similar actions grouped together intentionally) and adjust the ordering the items in each specific action menu from the position in the master list. Then we would get both consistent ordering and the ability to manually specify ordering to reflect categories or frequency of use.

#10 Updated by Lucas Di Pentima about 6 hours ago

Peter Amstutz wrote:

How hard would it be to add a confirmation dialog? Someone might select the action not knowing what it does. The confirmation dialog could also explain that this command makes it the new "head" version, but if they want a copy to work on without modifying "head", they should use "make a copy".

Confirmation dialog added at commit:arvados-workbench2|b115fc74
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/198/

Also available in: Atom PDF