https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422020-11-10T20:18:14ZArvadosArvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886052020-11-10T20:18:14ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/88605/diff?detail_id=85377">diff</a>)</li></ul> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886062020-11-10T20:18:28ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/88606/diff?detail_id=85378">diff</a>)</li></ul> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886072020-11-10T20:20:06ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/88607/diff?detail_id=85379">diff</a>)</li></ul> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886132020-11-11T15:03:44ZDaniel Kutyła
<ul></ul><p>New version first commit: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/f8c0598de3b7b55df719b6b5519d044ca256f367">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/f8c0598de3b7b55df719b6b5519d044ca256f367</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/170/"<a href="https://ci.arvados.org/job/developer-tests-workbench2/170/">developer-tests-workbench2: #170 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=170" alt="" /></a></a></p>
<p>Fix for post login redirect url</p> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886142020-11-11T15:03:55ZDaniel Kutyła
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886252020-11-11T21:42:35ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>It wasn't working consistently. Sometimes it would go to the correct page, sometimes it wouldn't.</p>
<p>On investigation, and it seems like setting <code>window.location.href</code> causes a page reload, and there is some kind of race condition where on the reload it would sometimes call ApiToken.componentDidMount leading to calling getTargetURL() again, but on the second time it would come back as null, so it then it would call navigateToRootProject. But this doesn't happen consistently.</p>
<p>I fixed this by calling replace() from react-redux-router, which doesn't trigger a page reload. I also changed the value stored in TargetURL to be just the path and query string.</p>
<p>17101-login-doesnt-navigate-user-back-to-original-path @ <a class="changeset" title="17101: Use redux router instead of setting window.location.href Arvados-DCO-1.1-Signed-off-by: P..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/54e734a4074911ce516a65c7195c84ad523adc75">arvados-workbench2|54e734a4074911ce516a65c7195c84ad523adc75</a></p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/171/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/171/">developer-tests-workbench2: #171 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=171" alt="" /></a></a></p>
<p>Take a look at my changes and if you don't have any issues with it, please merge.</p> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=886442020-11-12T17:12:33ZDaniel Kutyła
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '17101-login-doesnt-navigate-user-back-to-original-path' closes #17101 Arvados-DCO-..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/c28f185b9bf6a46bf02efd4a06439d14f09d6b8b">arvados-workbench2|c28f185b9bf6a46bf02efd4a06439d14f09d6b8b</a>.</p> Arvados - Bug #17101: Google/OIDC login doesn't navigate user back to original pathhttps://dev.arvados.org/issues/17101?journal_id=887462020-11-16T22:10:45ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>36</i></li></ul>